Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/trace: TestTraceFutileWakeup failure with "no consistent ordering of events possible" #51224

Open
bcmills opened this issue Feb 16, 2022 · 5 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 16, 2022

--- FAIL: TestTraceFutileWakeup (0.07s)
    trace_test.go:146: failed to parse trace: no consistent ordering of events possible
FAIL
FAIL	runtime/trace	4.859s

greplogs --dashboard -md -l -e 'FAIL: TestTraceFutileWakeup'

2022-02-16T16:06:39-f985833/dragonfly-amd64

(CC @mknyszek @prattmic @dvyukov per dev.golang.org/owners.)

This may be just another instance of #29707, but in #29707 (comment) @aclements suggesting that the failure mode reported there may be specific to C threads calling into Go, which doesn't seem to be the case here.

@bcmills bcmills added this to the Backlog milestone Feb 16, 2022
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 16, 2022
@prattmic
Copy link
Member

This is a case where we really need extra files from builders (like #49165).

We could potentially debug this given the malformed trace file. As-is there is basically nothing to work with.

@bcmills
Copy link
Contributor Author

bcmills commented Feb 24, 2022

Is it feasible to have the test dump a serialized trace file to stderr, or would that be too large?

@prattmic
Copy link
Member

I've considered that with core dumps. :) But those are definitely too big for the max builder output (2MB IIRC).

I'd have to double-check these, but given the relatively high iteration count in this test, I wouldn't be surprised if it was too big.

@prattmic
Copy link
Member

prattmic commented Feb 24, 2022

Oh nice, the trace is small enough to dump as a string. I'll send a CL for that.

  • 89KB raw trace
  • 120KB base64 encoded
  • 64KB raw trace gzipped
  • 86KB gzipped trace base64 encoded

@gopherbot
Copy link

Change https://go.dev/cl/387954 mentions this issue: runtime/trace: dump encoded trace to failure log

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Triage Backlog
Development

No branches or pull requests

3 participants