You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I also expected that such a tool would not depend on an unreleased version of Go. Code depending on an unreleased version of Go should be in a branch that is merged when Go 1.18 is released.
What did you see instead?
Reported compilation errors:
# golang.org/x/pkgsite/internal/godoc/internal/doc
../pkg/mod/golang.org/x/pkgsite@v0.0.0-20220213193454-9a991af47a09/internal/godoc/internal/doc/comment.go:241:17: undefined: strings.Cut
../pkg/mod/golang.org/x/pkgsite@v0.0.0-20220213193454-9a991af47a09/internal/godoc/internal/doc/comment.go:252:17: undefined: strings.Cut
../pkg/mod/golang.org/x/pkgsite@v0.0.0-20220213193454-9a991af47a09/internal/godoc/internal/doc/doc.go:160:86: undefined: any
../pkg/mod/golang.org/x/pkgsite@v0.0.0-20220213193454-9a991af47a09/internal/godoc/internal/doc/exports.go:184:14: undefined: token.TILDE
../pkg/mod/golang.org/x/pkgsite@v0.0.0-20220213193454-9a991af47a09/internal/godoc/internal/doc/exports.go:199:22: t.TypeParams undefined (type *ast.FuncType has no field or method TypeParams)
../pkg/mod/golang.org/x/pkgsite@v0.0.0-20220213193454-9a991af47a09/internal/godoc/internal/doc/reader.go:40:8: undefined: ast.IndexListExpr
../pkg/mod/golang.org/x/pkgsite@v0.0.0-20220213193454-9a991af47a09/internal/godoc/internal/doc/reader.go:133:8: undefined: ast.IndexListExpr
../pkg/mod/golang.org/x/pkgsite@v0.0.0-20220213193454-9a991af47a09/internal/godoc/internal/doc/reader.go:455:35: fun.Type.TypeParams undefined (type *ast.FuncType has no field or method TypeParams)
note: module requires Go 1.18
The text was updated successfully, but these errors were encountered:
hyangah
changed the title
affected/package: x/pkgsite@latest doesn't compile, requires Go 1.18
x/pkgsite: x/pkgsite@latest doesn't compile, requires Go 1.18
Feb 14, 2022
We did add what Jamal wrote above to the README, but I also understand that not everyone reads the README on every go get.
We wanted to support generics as early as possible, since people are already writing generic code. We chose to upgrade master to using to 1.18 beta2 rather than creating a new branch.
I'm sorry the experience isn't great, but 1.18 is coming soon.
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
What did you expect to see?
I expected pkgsite to compile and be usable.
I also expected that such a tool would not depend on an unreleased version of Go. Code depending on an unreleased version of Go should be in a branch that is merged when Go 1.18 is released.
What did you see instead?
Reported compilation errors:
The text was updated successfully, but these errors were encountered: