Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: new playground doesn't support plain text responses #51181

Closed
dominikh opened this issue Feb 14, 2022 · 3 comments
Closed

x/website: new playground doesn't support plain text responses #51181

dominikh opened this issue Feb 14, 2022 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website

Comments

@dominikh
Copy link
Member

The old playground supports serving plain text, by appending .go to the URL. See for example https://play.golang.org/p/zVLh02x4_tA.go - this can be used to directly curl code from the playground. The new playground doesn't seem to support this, and serves HTML even when appending .go.

@gopherbot gopherbot added this to the pkgsite/unplanned milestone Feb 14, 2022
@jamalc jamalc added website and removed pkgsite labels Feb 25, 2022
@jamalc jamalc self-assigned this Feb 25, 2022
@jamalc jamalc changed the title x/pkgsite: new playground doesn't support plain text responses x/website: new playground doesn't support plain text responses Feb 25, 2022
@jamalc jamalc added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 25, 2022
@gopherbot
Copy link

Change https://go.dev/cl/388016 mentions this issue: internal/play: playground supports plain text response

@gopherbot

This comment was marked as outdated.

gopherbot pushed a commit to golang/website that referenced this issue Mar 2, 2022
One test case added in CL 388016 depends on production resources,
specifically the snippet https://play.golang.org/p/MAohLsrz7JQ.go
served by the production instance of the Go playground.

This would be caught by TryBots where internet access is disabled,
but that didn't happen due to golang/go#51444.

Updates golang/go#51181.
Fixes golang/go#51439.

Change-Id: I4f1c5ea1a6ccad9ae4e5cbb749e3dee0b26731b5
Reviewed-on: https://go-review.googlesource.com/c/website/+/389394
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/389394 mentions this issue: cmd/golangorg: move test case that needs internet to live.txt

@rsc rsc unassigned jamalc Jun 22, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
Fixes golang/go#51181

Change-Id: I82f10320e86555a161cbfb5c5b79dfc331017003
Reviewed-on: https://go-review.googlesource.com/c/website/+/388016
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
One test case added in CL 388016 depends on production resources,
specifically the snippet https://play.golang.org/p/MAohLsrz7JQ.go
served by the production instance of the Go playground.

This would be caught by TryBots where internet access is disabled,
but that didn't happen due to golang/go#51444.

Updates golang/go#51181.
Fixes golang/go#51439.

Change-Id: I4f1c5ea1a6ccad9ae4e5cbb749e3dee0b26731b5
Reviewed-on: https://go-review.googlesource.com/c/website/+/389394
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
Trust: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Development

No branches or pull requests

3 participants