Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: Missing Retract field and ModPath struct in GoMod module reference docs #51163

Closed
pkwarren opened this issue Feb 12, 2022 · 2 comments
Labels
Documentation FrozenDueToAge help wanted modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@pkwarren
Copy link
Contributor

What version of Go are you using (go version)?

n/a

Does this issue reproduce with the latest release?

n/a

What operating system and processor architecture are you using (go env)?

n/a

What did you do?

Reviewed https://go.dev/ref/mod#go-mod-edit (source: https://github.com/golang/website/blob/master/_content/ref/mod.md#go-mod-edit-go-mod-edit)

What did you expect to see?

The description of the -json output should include the Retract []Retract field in the GoMod struct and include the ModPath struct (and the Module field should be of type ModPath).
This field and struct are present in the go help mod edit documentation.

What did you see instead?

Missing Retract field and ModPath struct.

@gopherbot gopherbot added this to the Unreleased milestone Feb 12, 2022
@dmitshur dmitshur added Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 14, 2022
@dmitshur
Copy link
Contributor

dmitshur commented Feb 14, 2022

Thanks for reporting. This is related to proposal #40357. CL 306334 and CL 309337 updated go help mod edit documentation, but the go.dev/ref/mod reference still needs to be updated.

CC @matloob, @bcmills.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 14, 2022
@bcmills bcmills modified the milestones: Unreleased, Backlog Feb 23, 2022
@gopherbot
Copy link

Change https://go.dev/cl/394818 mentions this issue: _content/ref: update module fields

@dmitshur dmitshur modified the milestones: Backlog, Unreleased Mar 23, 2022
@golang golang locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge help wanted modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants