Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: use EDNS to increase DNS packet size [freeze exception] [1.17 backport] #51162

Closed
gopherbot opened this issue Feb 12, 2022 · 4 comments
Closed

net: use EDNS to increase DNS packet size [freeze exception] [1.17 backport] #51162

gopherbot opened this issue Feb 12, 2022 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.8

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #51153 to be considered for backport to the next 1.17 minor release.

@gopherbot Please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 12, 2022
@gopherbot gopherbot mentioned this issue Feb 12, 2022
Closed
@gopherbot gopherbot added this to the Go1.17.8 milestone Feb 12, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/385374 mentions this issue: [release-branch.go1.17] net: send EDNS(0) packet length in DNS query

@gopherbot
Copy link
Author

Change https://go.dev/cl/386035 mentions this issue: [release-branch.go1.17] net: increase maximum accepted DNS packet to 1232 bytes

@dmitshur
Copy link
Contributor

Affected programs fail to work without a workaround. Approving per discussion in a release meeting. This backport applies to both 1.17 and 1.16.

See plan in #51153 (comment) for details of which CL is being requested for backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 16, 2022
gopherbot pushed a commit that referenced this issue Feb 17, 2022
@ianlancetaylor @dmitshur
[release-branch.go1.17] net: increase maximum accepted DNS packet to …
7d70adf 
…1232 bytes

The existing value of 512 bytes as is specified by RFC 1035.
However, the WSL resolver reportedly sends larger packets without
setting the truncation bit, which breaks using the Go resolver.
For 1.18 and backports, just increase the accepted packet size.
This is what GNU glibc does (they use 65536 bytes).

For 1.19 we plan to use EDNS to set the accepted packet size.
That will give us more time to test whether that causes any problems.

No test because I'm not sure how to write one and it wouldn't really
be useful anyhow.

For #6464
For #21160
For #44135
For #51127
For #51153
Fixes #51162

Change-Id: I0243f274a06e010ebb714e138a65386086aecf17
Reviewed-on: https://go-review.googlesource.com/c/go/+/386015
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 6e82ff8)
Reviewed-on: https://go-review.googlesource.com/c/go/+/386035
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Author

Closed by merging 7d70adf to release-branch.go1.17.

@knz knz mentioned this issue May 25, 2022
Closed
@golang golang locked and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.8
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot