Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: incorrect signature help for method expressions #51155

Open
findleyr opened this issue Feb 11, 2022 · 0 comments
Open

x/tools/gopls: incorrect signature help for method expressions #51155

findleyr opened this issue Feb 11, 2022 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@findleyr
Copy link
Contributor

Gopls shows the method signature rather than receiver type as the first parameter type in signatureHelp on method expressions:

image

This screenshot should instead show X.n(X, string) or n(X, string). Notably, the associated diagnostic shows the correct signature.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 11, 2022
@gopherbot gopherbot added this to the Unreleased milestone Feb 11, 2022
@hyangah hyangah added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 14, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/on-deck Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @findleyr