Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/doc, x/pkgsite: add comparable as predeclared type #51141

Closed
fzipp opened this issue Feb 11, 2022 · 4 comments
Closed

go/doc, x/pkgsite: add comparable as predeclared type #51141

fzipp opened this issue Feb 11, 2022 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite

Comments

@fzipp
Copy link
Contributor

fzipp commented Feb 11, 2022

CL 359778 added any as predeclared type to go/doc, but not comparable.

This is the reason why pkg.go.dev (via its internal copy of go/doc) doesn't linkify comparable, e.g. here.

/cc @findleyr
@fzipp fzipp added the pkgsite label Feb 11, 2022
@findleyr findleyr added this to the Go1.18 milestone Feb 11, 2022
@findleyr findleyr added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 11, 2022
@findleyr
Copy link
Contributor

Indeed, thank you for the investigation! Since this is an easy fix, I think we can probably get this into go/doc for 1.18.

CC @griesemer @jba

@jba jba self-assigned this Feb 11, 2022
@gopherbot
Copy link

Change https://go.dev/cl/385114 mentions this issue: go/doc: mark comparable predeclared

@findleyr
Copy link
Contributor

Reopening to track the equivalent change for pkgsite.

@findleyr findleyr reopened this Feb 11, 2022
@findleyr findleyr removed this from the Go1.18 milestone Feb 11, 2022
@gopherbot
Copy link

Change https://go.dev/cl/385198 mentions this issue: internal/godoc/internal/doc: mark comparable as predeclared

@rsc rsc unassigned jba Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fzipp @gopherbot @jba @findleyr