Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: release version v0.8.0 #51074

Closed
12 tasks done
findleyr opened this issue Feb 8, 2022 · 18 comments
Closed
12 tasks done

x/tools/gopls: release version v0.8.0 #51074

findleyr opened this issue Feb 8, 2022 · 18 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.8.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Feb 8, 2022 •
edited

gopls@v0.8.0 is the final gopls release planned before go 1.18, and will contain support for workspaces (via go.work), generics, and some features to help write fuzz tests.

Our milestone is currently scheduled for 2022-02-22, but we're planning to cut multiple prereleases in advance. This issue tracks our prereleases as well as the final v0.8.0 release.

  • update our release CI to run on gopls-release-branch.0.8
  • merge master into gopls-release-branch.0.8
  • update hard-coded version
  • update go.mod/go.sum (remove x/tools replace, update x/tools version)
  • tag gopls/v0.8.0-pre.1
  • tag gopls/v0.8.0-pre.2
  • tag gopls/v0.8.0-pre.3
  • update Github milestone
  • write release notes
  • create test plan
  • smoke test features
  • tag gopls/v0.8.0
@findleyr findleyr added this to the gopls/v0.8.0 milestone Feb 8, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 8, 2022
gopherbot pushed a commit to golang/tools that referenced this issue Feb 8, 2022
@findleyr
gopls: update codereview.cfg for the v0.8 branch
b9db714 
For golang/go#51074

Change-Id: I54e73fa4ee7ce57e78482e53aed25a10047ae745
Reviewed-on: https://go-review.googlesource.com/c/tools/+/384134
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/384135 mentions this issue: all: merge master (9b156ee) into gopls-release-branch.0.8

@gopherbot
Copy link

Change https://go.dev/cl/384134 mentions this issue: gopls: update codereview.cfg for the v0.8 branch

gopherbot pushed a commit to golang/tools that referenced this issue Feb 8, 2022
@findleyr
all: merge master (9b156ee) into gopls-release-branch.0.8
67ebb41 
For golang/go#51074

Merge List:

+ 2022-02-08 9b156ee internal/lsp/source: provide full documentation of builtin types
+ 2022-02-08 caecc2b internal/typeparams: add a generic form of types.AssignableTo
+ 2022-02-07 164402d internal/lsp/cache: set types.Config.GoVersion
+ 2022-02-07 6aaba77 internal/lsp/debug: add go version to gopls version output
+ 2022-02-04 414ec9c internal/lsp: add ListImports
+ 2022-02-04 d55d892 gopls/doc: how to request a particular gopls w/ sublime text
+ 2022-02-04 cf66aec gopls: update coc.nvim documentation for using go.work
+ 2022-02-04 597b165 internal/lsp/cache: use -workfile on 1.18
+ 2022-02-04 8305295 gopls: recognize the go.work file type
+ 2022-02-04 962260a internal/lsp/source: remove the unused source.DetectLanguage
+ 2022-02-04 3e30e21 gopls: remove the workspace_metadata command
+ 2022-02-04 25d2ab2 internal/lsp/cache: fixes for workspace invalidation
+ 2022-02-04 8d915b1 internal/lsp/cache: simplify workspace construction
+ 2022-02-04 77f5fa5 internal/lsp/cache: replace old go.work parser with x/mod
+ 2022-02-03 4da8ceb internal/lsp/source: remove the unused UpdateUserModFile invocation flag
+ 2022-02-03 727dfdb internal/lsp/source/completion: add conventional acronyms for type names
+ 2022-02-03 c009ab4 internal/lsp/completion: the inserted text should be what is shown to the user
+ 2022-02-03 eeb95ae gopls: make 'fastfuzzy' the default fuzzy matcher for workspace symbols
+ 2022-02-03 ea5e1dc internal/typeparams: add a helper to return the origin method
+ 2022-02-03 a739c97 internal/lsp/fake: retry ioutil.ReadFile on plan9 if it fails due to exclusive use
+ 2022-02-03 82366c6 internal/lsp/fake: in WriteFileData, retry writes that fail with ERROR_LOCK_VIOLATION on Windows
+ 2022-02-02 f6067dc gopls: cleanup the main help pages
+ 2022-02-02 dfda270 gopls: use the = form in flag parameter printing rather than a space
+ 2022-02-02 5ad7054 gopls: add long forms for all the 1 rune flags
+ 2022-02-02 217a9fc gopls: take control of the flag printing
+ 2022-02-02 afd524f gopls: clean up the help text
+ 2022-02-02 ec9a7de gopls: write out the raw usage text

Change-Id: Ia95ea1601c24eab898b6fdf60938982ad10a7b48
@gopherbot
Copy link

Change https://go.dev/cl/384194 mentions this issue: internal/lsp/debug: update hard-coded version for v0.8.0-pre.1

gopherbot pushed a commit to golang/tools that referenced this issue Feb 8, 2022
@findleyr
internal/lsp/debug: update hard-coded version for v0.8.0-pre.1
aa67a38 
Note while we normally set the version to the final version (v0.8.0), we
are anticipating multiple prereleases and so include the prerelease
label to help differentiate them.

For golang/go#51074

Change-Id: I4b8c1ca8e9002f285b0d9f28b1af2ff49ce8ee74
Reviewed-on: https://go-review.googlesource.com/c/tools/+/384194
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/384116 mentions this issue: gopls: update go.mod file for v0.8.0-pre.1

gopherbot pushed a commit to golang/tools that referenced this issue Feb 8, 2022
@findleyr
gopls: update go.mod file for v0.8.0-pre.1
9466be7 
For golang/go#51074

Change-Id: Ia39e065480248a85a46d2b3fbbc3acb4f1ae927e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/384116
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@findleyr findleyr self-assigned this Feb 17, 2022
@gopherbot
Copy link

Change https://go.dev/cl/386614 mentions this issue: internal/lsp/debug: update hard-coded version for v0.8.0-pre.2

gopherbot pushed a commit to golang/tools that referenced this issue Feb 17, 2022
@findleyr
internal/lsp/debug: update hard-coded version for v0.8.0-pre.2
1c32d8b 
For golang/go#51074

Change-Id: I9b69aa22083546b8ae9f7bc2ab6a8bde91c24d4b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/386614
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/386615 mentions this issue: gopls: update go.mod file for v0.8.0-pre.2

gopherbot pushed a commit to golang/tools that referenced this issue Feb 17, 2022
@findleyr
gopls: update go.mod file for v0.8.0-pre.2
fe6cc9a 
For golang/go#51074

Change-Id: Ieefa210ddbef1b4483d666f1fbfcab453ea21e5e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/386615
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/386734 mentions this issue: gopls: update go.mod file for v0.8.0-pre.2 to pick up CL 386537

gopherbot pushed a commit to golang/tools that referenced this issue Feb 18, 2022
@findleyr
gopls: update go.mod file for v0.8.0-pre.2 to pick up CL 386537
f1bc086 
For golang/go#51074

Change-Id: I5471419cfe554ff6be3181e2594dbf5e6e7f421d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/386734
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@mvdan
Copy link
Member

mvdan commented Feb 20, 2022

@findleyr could we include the upcoming gofumpt release in gopls v0.8.0? I haven't released it yet but it's long overdue, so I can expedite a release by tomorrow :) I realise it's a bit late, but given how major gopls releases don't come often, and then each editor takes their time to ship the updated gopls, I'd prefer not to further delay by six months.

By the way, I see https://github.com/golang/go/milestone/244 still has over twenty open issues, so I wonder if those need to be moved to a v0.9 milestone.

@findleyr
Copy link
Contributor Author

@mvdan sure, we can upgrade gofumpt if you can do a release sometime tomorrow.

By the way, I see https://github.com/golang/go/milestone/244 still has over twenty open issues, so I wonder if those need to be moved to a v0.9 milestone.

Indeed, I rolled over most of those to v0.8.1, thanks. (what remains is either in-progress, documentation, or process).

@mvdan
Copy link
Member

mvdan commented Feb 22, 2022

Sounds good. I'll have v0.3.0 out today and I'll also send a CL for gopls. Note that gofumpt's options now include two fields from go mod edit -json, so I'll try to wire those up too.

@mvdan
Copy link
Member

mvdan commented Feb 22, 2022

gofumpt v0.3.0 released, and I tried to wire it up in gopls but failed: https://go-review.googlesource.com/c/tools/+/387374

@findleyr
Copy link
Contributor Author

Thanks @mvdan. I'll wire it up.

BTW, it looks like the documentation for ModulePath is a bit broken, containing some content from the documentation for LangVersion:

// ModulePath corresponds to the Go module path which contains the source
// code being formatted. When inside a Go module, ModulePath should be:
// rules which require new language features. When inside a Go module,
// LangVersion should generally be specified as the result of:

@mvdan
Copy link
Member

mvdan commented Feb 23, 2022

Oh boy, thanks for spotting that :)

@gopherbot
Copy link

Change https://go.dev/cl/388437 mentions this issue: all: merge master (abc106c) into gopls-release-branch.0.8

gopherbot pushed a commit to golang/tools that referenced this issue Feb 28, 2022
@findleyr
all: merge master (abc106c) into gopls-release-branch.0.8
1868799 
Also add a replace directive to gopls/go.mod.

Updates golang/go#51074

Conflicts:

- gopls/go.mod (due to gofumpt update)

Merge List:

+ 2022-02-28 abc106c gopls/integration/govim: build gopls using go1.18rc1
+ 2022-02-28 c2ddf3d internal/lsp: add quick fix for unsupported feature
+ 2022-02-28 0e44f7a gopls/doc/advanced.md: correct commands for unstable version build
+ 2022-02-25 acdddf6 go/ssa: allows right operand of a shift to be signed.
+ 2022-02-25 9ffa3ad internal/lsp: Provide completions for test function definitions
+ 2022-02-24 b7525f4 internal/lsp: hash go version into package key
+ 2022-02-24 5210e0c gopls: wire in LangVersion and ModulePath for gofumpt formatting
+ 2022-02-24 e6ef770 go/types/typeutil: don't recurse into constraints when hashing tparams
+ 2022-02-23 258e473 internal/lsp/source: disable the useany analyzer by default
+ 2022-02-23 b7d2949 internal/lsp: don't store diagnostics for builtin.go
+ 2022-02-23 4f21f7a gopls: update gofumpt to v0.3.0
+ 2022-02-22 3e31058 internal/imports: update to permit multiple main modules
+ 2022-02-22 43f084e internal/typesinternal: update typesinternal for 1.18
+ 2022-02-18 897bd77 internal/gocommand: remove support for -workfile
+ 2022-02-17 e6a7e13 go/analysis/tools/internal/checker: add support for RunDespiteError

Change-Id: I4ca5a581cb276b904f4a9d73d686aaa7cb0c6093
@gopherbot
Copy link

Change https://go.dev/cl/388438 mentions this issue: internal/lsp/debug: update hard-coded version for v0.8.0

gopherbot pushed a commit to golang/tools that referenced this issue Mar 1, 2022
@findleyr
internal/lsp/debug: update hard-coded version for v0.8.0
68c2d84 
For golang/go#51074

Change-Id: I37c665d226ec83e901c4d85b451d1ca65c2043a2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/388438
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link

Change https://go.dev/cl/388694 mentions this issue: gopls: update go.mod file for v0.8.0

gopherbot pushed a commit to golang/tools that referenced this issue Mar 1, 2022
@findleyr
gopls: update go.mod file for v0.8.0
f86e71d 
For golang/go#51074

Change-Id: I6ebe3470d4a3113566eaa26f32e611d3bb8ffcd1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/388694
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/389714 mentions this issue: gopls: update go.mod to pick up CL 389494

gopherbot pushed a commit to golang/tools that referenced this issue Mar 3, 2022
@findleyr
gopls: update go.mod to pick up CL 389494
86f5b03 
Update to include recently cherry-picked x/tools changes.

For golang/go#51074

Change-Id: Iae465b09b9c1f751c118d43eb37910696a72ebdd
Reviewed-on: https://go-review.googlesource.com/c/tools/+/389714
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@findleyr
Copy link
Contributor Author

findleyr commented Mar 3, 2022

Release is complete.

@findleyr findleyr closed this as completed Mar 3, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.8.0
Development

No branches or pull requests
3 participants
@mvdan @gopherbot @findleyr