Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: Add support for workspace/{Will,Did}{Rename,Delete,Create}Files methods #51037

Open
jan-xyz opened this issue Feb 6, 2022 · 1 comment
Open

x/tools/gopls: Add support for workspace/{Will,Did}{Rename,Delete,Create}Files methods #51037

jan-xyz opened this issue Feb 6, 2022 · 1 comment
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@jan-xyz
Copy link

jan-xyz commented Feb 6, 2022 •
edited
Loading

In order to make refactoring and code base cleanups easier and be on-par with IDE's I would wish for more high-level workspace refactoring capabilities and to move files around. The functions in the LSP spec were added with the 3.16 specification and are already available:

From a user perspective I can imagine that this also makes sure that previously private tokens are now exported and that the appropriate packages get imported. I also thought about moving accompanying *_test.go files, but that might be easier if the user just does it themselves.

I am not a VS code user, but from the pull requests in the repo I think it's already supported and Neovim has a tracking issue.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 6, 2022
@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2022
@suzmue suzmue modified the milestones: Unreleased, gopls/on-deck Feb 7, 2022
@suzmue suzmue added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Feb 7, 2022
@suzmue suzmue self-assigned this Mar 15, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/574256 mentions this issue: internal/lsp: support rename files for a single directory

@suzmue suzmue removed their assignment Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@jan-xyz @suzmue @gopherbot