Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: inconsistent text render output in screentest #51020

Open
jamalc opened this issue Feb 4, 2022 · 1 comment
Open

x/pkgsite: inconsistent text render output in screentest #51020

jamalc opened this issue Feb 4, 2022 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/unplanned

Comments

@jamalc
Copy link

jamalc commented Feb 4, 2022

The testcase for "test empty jump to modal" in tests/screentest/testcases.txt occasionally fails because the font rendering on the Close button is inconsistent. Here is a similar issue with puppeteer, it seems to be limited to linux platforms in both cases. There might be some combination of chrome flags we can add to the headless-shell command to disable font smoothing or antialiasing.
@jamalc jamalc added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Feb 4, 2022
@gopherbot gopherbot added this to the pkgsite/unplanned milestone Feb 4, 2022
@gopherbot
Copy link

Change https://golang.org/cl/383198 mentions this issue: test/screentest: disable flaky test

gopherbot pushed a commit to golang/pkgsite that referenced this issue Feb 7, 2022
@jamalc
test/screentest: disable flaky test
b4e519e 
For golang/go#51020.

Change-Id: If7424a89d323db7b2aecf4b2eec087159b979139
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/383198
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
2 participants
@gopherbot @jamalc