Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/modfile: TestSumUpdateFixesDiagnostics failures on Windows with "another process has locked a portion of the file." #50971

Closed
bcmills opened this issue Feb 2, 2022 · 3 comments
Closed

x/tools/gopls/internal/regtest/modfile: TestSumUpdateFixesDiagnostics failures on Windows with "another process has locked a portion of the file." #50971

bcmills opened this issue Feb 2, 2022 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 2, 2022

greplogs --dashboard -md -l -e '(?ms)another process has locked a portion of the file.*^FAIL\s+golang\.org/x/tools/gopls' --since=2021-01-01

2022-02-01T20:35:43-461d130-5522f8c/windows-amd64-longtest
2021-08-16T23:32:14-10bcabd-8ff16c1/windows-amd64-race

This may be a test-only bug (not clear to me at this point). I will investigate.

(CC @findleyr)
@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 2, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 2, 2022
@bcmills bcmills self-assigned this Feb 2, 2022
@gopherbot gopherbot added this to the Unreleased milestone Feb 2, 2022
@bcmills bcmills mentioned this issue Feb 2, 2022
Open
@gopherbot
Copy link

Change https://golang.org/cl/382414 mentions this issue: internal/lsp/fake: in WriteFileData, retry writes that fail with ERROR_LOCK_VIOLATION on Windows

@bcmills
Copy link
Contributor Author

bcmills commented Feb 2, 2022

This may be a test-only bug (not clear to me at this point).

This may actually be a problem with the LSP protocol itself. This failure occurs due to an editor-initiated write to the go.mod file racing with a gopls -initiated read.

@bcmills
Copy link
Contributor Author

bcmills commented Feb 2, 2022

(I think I know how to fix the test, but not the protocol race.)

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 2, 2022
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2022
@rsc rsc unassigned bcmills Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot