Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: create gopls-release-branch.0.8 #50957

Closed
findleyr opened this issue Feb 1, 2022 · 4 comments
Closed

x/tools/gopls: create gopls-release-branch.0.8 #50957

findleyr opened this issue Feb 1, 2022 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Go Release Team
Milestone
gopls/v0.8.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Feb 1, 2022

We are using the v0.8.0 milestone for Go 1.18 support. This milestone is scheduled for the end of February, but we'd like to start cutting prereleases soon as we add features.

Could someone on @golang/release assist with creating the new branch? Thanks.
@findleyr findleyr added this to the gopls/v0.8.0 milestone Feb 1, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 1, 2022
@dmitshur
Copy link
Contributor

dmitshur commented Feb 1, 2022

Of course.

What would you like the branching point to be, the latest commit on the master branch? Is creating it today okay?

@findleyr
Copy link
Contributor Author

findleyr commented Feb 1, 2022

What would you like the branching point to be

The latest commit on master works.

Is creating it today okay?

Yes, not super urgent but creating it today would be great.

Thanks!

@dmitshur
Copy link
Contributor

dmitshur commented Feb 1, 2022

Ok, I've created a new branch named gopls-release-branch.0.8 in x/tools (next in sequence following the existing gopls-release-branch.0.7 branch). Its initial commit was golang/tools@461d130:

https://go.googlesource.com/tools/+/refs/heads/gopls-release-branch.0.8

If something's not right, please comment or reopen.

I suspect owners of gopls may have an existing path to create these branches, so if asking us becomes too tedious, we can explore that next time.

@dmitshur dmitshur closed this as completed Feb 1, 2022
@findleyr
Copy link
Contributor Author

findleyr commented Feb 1, 2022

so if asking us becomes too tedious, we can explore that next time.

I think it is only tedious for the release team, who must deal with the interrupt. Let me know if this workflow doesn't work for you :)

@toothrot toothrot added this to Done in Go Release Team Feb 1, 2022
@golang golang locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
gopls/v0.8.0
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @findleyr