Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: error in example #5095

Closed
tebeka opened this issue Mar 21, 2013 · 3 comments
Closed

cmd/cgo: error in example #5095

tebeka opened this issue Mar 21, 2013 · 3 comments
Milestone

Comments

@tebeka
Copy link
Contributor

tebeka commented Mar 21, 2013

The docs at http://golang.org/cmd/cgo/ say:

---
Any C function that returns a value may be called in a multiple assignment context to
retrieve both the return value and the C errno variable as an error. For example:

n, err := C.atoi("abc")

---

This has two errors:
1. Need to wrap "abc" in C.CString
2. atoi does not set errno (at least on Linux), strtol does

I suggest to change the example to
    // Will generate error since base 100 is too large
    n, err := C.strtol(C.CString("10"), nil, 100)
@minux
Copy link
Member

minux commented Mar 21, 2013

Comment 1:

sure, feel free to mail a CL.

Labels changed: added priority-later, go1.1, removed priority-triage.

Status changed to Accepted.

@tebeka
Copy link
Contributor Author

tebeka commented Mar 21, 2013

Comment 2:

https://golang.org/cl/7888047

@robpike
Copy link
Contributor

robpike commented Mar 23, 2013

Comment 3:

Fixed by https://golang.org/cl/7888047

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants