Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: "compile: loop" compiler bug? [1.17 backport] #50942

Closed
gopherbot opened this issue Feb 1, 2022 · 3 comments
Closed

cmd/asm: "compile: loop" compiler bug? [1.17 backport] #50942

gopherbot opened this issue Feb 1, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.7

Comments

@gopherbot
Copy link

@manjari25 requested issue #49716 to be considered for backport to the next 1.17 minor release.

@gopherbot please consider this for backport to 1.17, it's a regression.

While upgrading to 1.17, several of our targets fail to build due to this error. We have verified that this fix works for us by patching it. We do not see any other workaround.

We would like to throw a voice out there that this solves a real regression for us that was introduced in 1.17 and we'd like to be able to use the latest release again :)

cc: @cherrymui Thanks so much for the fix!
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 1, 2022
@gopherbot gopherbot mentioned this issue Feb 1, 2022
Closed
@gopherbot gopherbot added this to the Go1.17.7 milestone Feb 1, 2022
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Feb 3, 2022
@toothrot
Copy link
Contributor

toothrot commented Feb 3, 2022

Approved. This is a serious problem with no workaround.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 3, 2022
@gopherbot
Copy link
Author

Change https://golang.org/cl/383214 mentions this issue: [release-branch.go1.17] cmd/internal/obj/x86: modify the threshold of assert loop for span6

@gopherbot
Copy link
Author

Closed by merging 17e179e to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Feb 7, 2022
@zhouguangyuan0718 @cherrymui
[release-branch.go1.17] cmd/internal/obj/x86: modify the threshold of…
17e179e 
… assert loop for span6

Updates #49716.
Fixes #50942.

Change-Id: I7ed73f874c2ee1ee3f31c9c4428ed484167ca803
Reviewed-on: https://go-review.googlesource.com/c/go/+/366094
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: Heschi Kreinick <heschi@google.com>
(cherry picked from commit 14f2b2a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/383214
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
@knz knz mentioned this issue May 25, 2022
Closed
@golang golang locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.7
Development

No branches or pull requests
2 participants
@toothrot @gopherbot