Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: pressing the 'X' button doesn't close the search dialogue #50895

Closed
katiehockman opened this issue Jan 28, 2022 · 3 comments
Closed

x/pkgsite: pressing the 'X' button doesn't close the search dialogue #50895

katiehockman opened this issue Jan 28, 2022 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
Unreleased

Comments

@katiehockman
Copy link
Contributor

What is the URL of the page with the issue?

All package pages (my screenshot is of: https://pkg.go.dev/crypto/tls)

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36

Issue

Pressing the 'X' button on the search dialogue doesn't close the dialog box. Pressing 'Esc' does that correctly, though.

To reproduce, go to https://pkg.go.dev/crypto/tls, press 'F' to open the search dialogue, then press the 'X' button in the top right corner of the dialogue.

/cc @golang/pkgsite
@katiehockman katiehockman added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Jan 28, 2022
@katiehockman katiehockman added this to the Unreleased milestone Jan 28, 2022
@jamalc
Copy link

jamalc commented Feb 1, 2022 •
edited

I'm having trouble reproducing this issue. Is it still happening for you on all pages?

@katiehockman
Copy link
Contributor Author

Yes it's still happening, but for some reason it doesn't reproduce if I use Chrome logged on with corp. Try using an incognito window to reproduce it, since that seems to consistently show the problem for me.

@gopherbot
Copy link

Change https://go.dev/cl/392954 mentions this issue: static/frontend: fix close button on modal dialog

@jamalc jamalc mentioned this issue Apr 22, 2022
Closed
@rsc rsc unassigned jamalc Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @jamalc @katiehockman