Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: stop using http.DefaultServeMux #50894

Closed
toothrot opened this issue Jan 28, 2022 · 1 comment
Closed

x/build/cmd/coordinator: stop using http.DefaultServeMux #50894

toothrot opened this issue Jan 28, 2022 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

We should prevent dependencies from adding handlers other than ones we explicitly want. There are currently a handful of extra handlers that, while harmless, are not intentionally exposed.
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 28, 2022
@toothrot toothrot added this to the Unreleased milestone Jan 28, 2022
@toothrot toothrot self-assigned this Jan 28, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 28, 2022
@toothrot toothrot added this to In Progress in Go Release Team Jan 28, 2022
@gopherbot
Copy link

Change https://golang.org/cl/381737 mentions this issue: cmd/coordinator: stop using http.DefaultServeMux

Go Release Team automation moved this from In Progress to Done Jan 28, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@toothrot @gopherbot