Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestUDPReadSizeError failure with read of length 0 #50870

Closed
bcmills opened this issue Jan 27, 2022 · 2 comments
Closed

net: TestUDPReadSizeError failure with read of length 0 #50870

bcmills opened this issue Jan 27, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 27, 2022 

--- FAIL: TestUDPReadSizeError (0.12s)
    udpsock_test.go:433: got 0; want 19
FAIL
FAIL	net	8.513s

greplogs --dashboard -md -l -e 'FAIL: TestUDPReadSizeError'

2022-01-27T19:55:38-1a2435c/darwin-amd64-11_0

The assertion is from this section of the test:
https://cs.opensource.google/go/go/+/master:src/net/udpsock_test.go;l=420-432;drc=b55cbbb9e76969d67fbc6e264a584ad18c2f95fa

The test was added in CL 92475 (CC @m4ns0ur), and this is the first such failure I can find in the logs.

The test appears to accept a Timeout error on any platform — or any error at all on Windows — but then still expects the Read to have returned an exact number of bytes. However, it's not clear to me how we can be sure that the Write has actually made it through the kernel before the timeout fires.
@bcmills bcmills added this to the Backlog milestone Jan 27, 2022
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 28, 2022
@mknyszek
Copy link
Contributor

CC @neild

@gopherbot
Copy link

Change https://golang.org/cl/382537 mentions this issue: net: remove an arbitrary timeout in TestUDPReadSizeError

@golang golang locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@mknyszek @bcmills @gopherbot