Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/modfile: failures with "exclusive use file already open" on plan9 #50840

Closed
bcmills opened this issue Jan 26, 2022 · 2 comments
Closed

x/tools/gopls/internal/regtest/modfile: failures with "exclusive use file already open" on plan9 #50840

bcmills opened this issue Jan 26, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. OS-Plan9 Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.8.0

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 26, 2022

greplogs --dashboard -md -l -e 'FAIL: .*\n .*exclusive use file already open'

2022-01-20T16:31:11-ab35822-59122f8/plan9-amd64-0intro
2021-11-29T20:12:13-6e52f51-f598e29/plan9-386-0intro
2021-11-04T17:07:48-84e69e7-5772877/plan9-386-0intro
2021-09-22T19:37:42-efaec4e-5b75a9b/plan9-386-0intro
2021-07-02T16:14:50-7edcfe5-03761ed/plan9-386-0intro
2021-06-17T14:53:37-463a76b-4dede02/plan9-386-0intro
2021-05-20T20:37:02-2275bb5-baa934d/plan9-386-0intro
2021-05-04T21:16:16-f03daea-cd28ca3/plan9-386-0intro
2021-04-18T17:40:12-07295ca-4efd581/plan9-386-0intro
2021-04-06T21:43:19-c602466-0a51047/plan9-386-0intro

On Plan 9, unlike other platforms, file-locking is actually enforced, not advisory: if some process (such as the go command) has a lock on the go.mod file, it cannot be opened concurrently by another process. (Compare #48572.)

Probably the right long-term fix is to update whatever is reading these files to retry the plan9 error.
As a short-term fix, we should probably skip the modfile tests on Plan 9.

(CC @0intro @findleyr)
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 26, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jan 26, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Jan 26, 2022

(I'll send a CL to add the skip, probably tomorrow.)

@bcmills bcmills self-assigned this Jan 26, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/on-deck Jan 27, 2022
@gopherbot
Copy link

Change https://golang.org/cl/381734 mentions this issue: internal/lsp/fake: retry ioutil.ReadFile on plan9 if it fails due to exclusive use

@bcmills bcmills mentioned this issue Feb 2, 2022
Open
@rsc rsc unassigned bcmills Jun 22, 2022
@findleyr findleyr modified the milestones: gopls/later, gopls/v0.8.0 Jul 1, 2022
@golang golang locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. OS-Plan9 Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.8.0
Development

No branches or pull requests
4 participants
@hyangah @bcmills @gopherbot @findleyr