Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/race: NoRaceMutexPureHappensBefore failures [1.16 backport] #50832

Closed
gopherbot opened this issue Jan 26, 2022 · 3 comments
Closed

runtime/race: NoRaceMutexPureHappensBefore failures [1.16 backport] #50832

gopherbot opened this issue Jan 26, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16.14

Comments

@gopherbot
Copy link

@bcmills requested issue #35745 to be considered for backport to the next 1.16 minor release.

@gopherbot, please backport to Go 1.16. This is a test-only fix, and the test can spuriously fail in TryBot and release-testing runs for other backports.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 26, 2022
@gopherbot gopherbot mentioned this issue Jan 26, 2022
Closed
@gopherbot gopherbot added this to the Go1.16.14 milestone Jan 26, 2022
@gopherbot
Copy link
Author

Change https://golang.org/cl/381034 mentions this issue: [release-branch.go1.16] testing/race: fixing intermittent test failure

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 27, 2022
@dmitshur
Copy link
Contributor

Approved for backport.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jan 27, 2022
gopherbot pushed a commit that referenced this issue Jan 27, 2022
@dfava @dmitshur
[release-branch.go1.16] testing/race: fixing intermittent test failure
6cbcf58 
Test NoRaceMutexPureHappensBefore in runtime/race/testdata/mutex_test.go
expects the second spawned goroutine to run after the first.  The test
attempts to force this scheduling with a 10 millisecond wait.  Following
a suggestion by Bryan Mills, we force this scheduling using a shared
variable whose access take place within the existing mutex.

Fixes #50832.
Updates #35745.

Change-Id: Ib23ec51492ecfeed4752e020401dd25755a669ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/291292
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit aaed6cb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/381034
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Author

Closed by merging 6cbcf58 to release-branch.go1.16.

@golang golang locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16.14
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot