Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: remove bitbucket VCS probing [1.17 backport] #50812

Closed
gopherbot opened this issue Jan 25, 2022 · 4 comments
Closed

cmd/go: remove bitbucket VCS probing [1.17 backport] #50812

gopherbot opened this issue Jan 25, 2022 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go release-blocker
Milestone
Go1.17.7

Comments

@gopherbot
Copy link

@bcmills requested issue #50810 to be considered for backport to the next 1.17 minor release.

@gopherbot, please backport to Go 1.16 and 1.17. This removes a dependency on an implementation detail of a service external to the Go project.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 25, 2022
@gopherbot gopherbot mentioned this issue Jan 25, 2022
Closed
@gopherbot gopherbot added this to the Go1.17.7 milestone Jan 25, 2022
@dmitshur dmitshur added the GoCommand cmd/go label Jan 25, 2022
@dmitshur
Copy link
Contributor

I think cmd/go owners will be able to review this candidate soon, and perhaps this warrants release-blocker so it won't miss next month's minor release by accident.

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jan 26, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 26, 2022
@bcmills
Copy link
Contributor

bcmills commented Jan 26, 2022

This cmd/go change adapts to a change in an external service (Bitbucket). The risk of the change is low because it only affects direct fetches of repositories hosted on that service in particular. (Moreover, the cmd/go fix was contributed by the maintainers of that service, so I trust that if there is an unforeseen problem they will follow up appropriately.)

Approving for the next Go 1.17 minor release.

@gopherbot
Copy link
Author

Change https://golang.org/cl/380996 mentions this issue: cmd/go: remove mercurial from bitbucket vcs options

@gopherbot
Copy link
Author

Closed by merging faa0409 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Feb 7, 2022
@aethanol @cherrymui
[release-branch.go1.17] cmd/go: remove mercurial from bitbucket vcs o…
faa0409 
…ptions

Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket

Fixes #50812.
Updates #50810.

Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d
Reviewed-on: https://go-review.googlesource.com/c/go/+/371720
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: Bryan Mills <bcmills@google.com>
(cherry picked from commit 5b1b80b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/380996
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go release-blocker
Projects
None yet
Milestone
Go1.17.7
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot