cmd/go: remove bitbucket VCS probing #50810
Labels
FrozenDueToAge
GoCommand
cmd/go
modules
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
bcmills
added
NeedsFix
|
@gopherbot, please backport to Go 1.16 and 1.17. This removes a dependency on an implementation detail of a service external to the Go project. |
|
Backport issue(s) opened: #50811 (for 1.16), #50812 (for 1.17). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
|
Change https://golang.org/cl/371720 mentions this issue: |
|
Change https://golang.org/cl/380996 mentions this issue: |
|
Change https://golang.org/cl/380998 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Feb 7, 2022
…ptions Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket Fixes #50812. Updates #50810. Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d Reviewed-on: https://go-review.googlesource.com/c/go/+/371720 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Trust: Bryan Mills <bcmills@google.com> (cherry picked from commit 5b1b80b) Reviewed-on: https://go-review.googlesource.com/c/go/+/380996 Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
gopherbot
pushed a commit
that referenced
this issue
Feb 7, 2022
…ptions Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket Fixes #50811. Updates #50810. Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d Reviewed-on: https://go-review.googlesource.com/c/go/+/371720 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Trust: Bryan Mills <bcmills@google.com> (cherry picked from commit 5b1b80b) Reviewed-on: https://go-review.googlesource.com/c/go/+/380998 Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
jproberts
pushed a commit
to jproberts/go
that referenced
this issue
Jun 21, 2022
Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket Fixes golang#50810. Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d Reviewed-on: https://go-review.googlesource.com/c/go/+/371720 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Trust: Bryan Mills <bcmills@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The
gocommand previously probedbitbucketservers in case of a 403 status to figure out which VCS command (gitorhg) to use to fetch repositories hosted on Bitbucket.Bitbucket no longer supports
hg(https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket), and per discussion on CL 371720 they would like to change the status code returned by their servers — an implementation detail currently hard-coded bygo get.Since the choice of VCS tool is no longer ambiguous, we should remove the VCS probing logic. That will also make the
gocommand's behavior for private Bitbucket repos more closely match its behavior for other private repos in general.The text was updated successfully, but these errors were encountered: