Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: specify 'source' of template file diagnostic messages #50786

Closed
hyangah opened this issue Jan 24, 2022 · 3 comments
Closed

x/tools/gopls: specify 'source' of template file diagnostic messages #50786

hyangah opened this issue Jan 24, 2022 · 3 comments
Labels
FeatureRequest FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.8.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Jan 24, 2022

gopls version: v0.7.5
go version: go1.17.5

Template diagnostics is missing source and code info.

[Trace - 14:23:45.054 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/hakim/ww/some.gotmpl","version":2,"diagnostics":[{"range":{"start":{"line":0,"character":0},"end":{"line":0,"character":5}},"severity":1,"message":"missing value for command"}]}

Moreover, it would be nice gopls responds to the following codeAction requests with links to documentation like other compiler/syntax/lint messages, but I am afraid there is no good reference page to use yet.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 24, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jan 24, 2022
@hyangah hyangah added FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 24, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/unplanned Jan 24, 2022
@hyangah
Copy link
Contributor Author

hyangah commented Jan 25, 2022

cc @pjweinb

@gopherbot
Copy link

Change https://golang.org/cl/380974 mentions this issue: internal/template: return a Source with template diagnostics

@pjweinb
Copy link

pjweinb commented Mar 3, 2022

Ever since https://golang.org/cl/380974 was submitted, gopls returns a source on template errors. Is there some reason this feature request should be open?

@rsc rsc unassigned pjweinb Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.8.0
Development

No branches or pull requests
4 participants
@hyangah @pjweinb @gopherbot @findleyr