Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: confusing assignment mismatch error when indexing map with invalid key #50762

Closed
Snaipe opened this issue Jan 22, 2022 · 1 comment
Closed

cmd/compile: confusing assignment mismatch error when indexing map with invalid key #50762

Snaipe opened this issue Jan 22, 2022 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@Snaipe
Copy link

Snaipe commented Jan 22, 2022

What version of Go are you using (go version)?

$ go version
go version go1.17.6 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/snaipe/.local/var/cache/go-build"
GOENV="/home/snaipe/.local/etc/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/snaipe/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/snaipe/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.6"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2452324536=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Compiling this invalid program: https://play.golang.com/p/QWTPYt1MIep

... yields the following error:

./prog.go:5:8: assignment mismatch: 2 variables but 1 value
./prog.go:5:13: undefined: invalid

While the second error is completely reasonable, and probably what I would expect to see first and foremost, the first error is rather confusing. When fixing compile errors with a lot more messages, and getting a bit tunnel-visioned on fixing them one after the other, I was left wondering what was wrong with my program and attempting to change some variable names in hope of fixing it, only to realize a couple of minutes later that the undefined key was the actual issue.

This is of course pretty minor, but I wish the compiler hadn't shown me the first error since it threw me for a loop.
@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 23, 2022
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Jan 23, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
@seankhliao
Copy link
Member

The error has improved since 1.18

main » go1.18.10 run .
# go.seankhliao.com/testrepo0193
./main.go:5:2: r declared but not used
./main.go:5:5: ok declared but not used
./main.go:5:13: undefined: invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@Snaipe @ianlancetaylor @gopherbot @seankhliao