x/tools/gopls/internal/regtest/workspace: frequent failures in TestWatchReplaceTargets with ‘Unmet: completed work "diagnosing files changed on disk"’ #50748

bcmills · 2022-01-21T20:10:33Z

greplogs --dashboard -md -l -e 'FAIL: TestWatchReplaceTargets .*\n(?: .*\n)* .*Unmet: completed work "diagnosing files changed on disk"'

The text was updated successfully, but these errors were encountered:

bcmills · 2022-01-21T20:11:27Z

(CC @findleyr)

Given the relatively high failure rate, I'll mail a test-skip until this can be investigated in more depth.

gopherbot · 2022-01-21T20:51:29Z

Change https://golang.org/cl/380215 mentions this issue: gopls/internal/regtest/workspace: temporarily skip TestWatchReplaceTargets

…rgets This test has a high failure rate on the builders, and the failures appear to be mostly platform-independent. This change skips the test until the failures can be diagnosed and fixed. For golang/go#50748 Change-Id: Iadfda7345f3dcbafa61338469aa6dc45e1d85a49 Reviewed-on: https://go-review.googlesource.com/c/tools/+/380215 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>

gopherbot · 2023-05-22T14:29:21Z

Change https://go.dev/cl/496879 mentions this issue: gopls/internal/lsp/regtest: delete TestWatchReplaceTargets

gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 21, 2022

gopherbot added this to the Unreleased milestone Jan 21, 2022

hyangah modified the milestones: Unreleased, gopls/unplanned Jan 25, 2022

hyangah added NeedsFix The path to resolution is known, but the work has not been done. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 25, 2022

gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Jan 25, 2022

findleyr modified the milestones: gopls/unplanned, gopls/later Jun 1, 2022

findleyr mentioned this issue Jul 14, 2022

x/tools/gopls: unskip all previously flaky regtests #53878

Closed

8 tasks

findleyr added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jul 14, 2022

findleyr modified the milestones: gopls/later, gopls/v0.12.0 May 21, 2023

gopherbot closed this as completed in golang/tools@9ca66ba May 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls/internal/regtest/workspace: frequent failures in TestWatchReplaceTargets with ‘Unmet: completed work "diagnosing files changed on disk"’ #50748

x/tools/gopls/internal/regtest/workspace: frequent failures in TestWatchReplaceTargets with ‘Unmet: completed work "diagnosing files changed on disk"’ #50748

bcmills commented Jan 21, 2022

bcmills commented Jan 21, 2022

gopherbot commented Jan 21, 2022

gopherbot commented May 22, 2023

x/tools/gopls/internal/regtest/workspace: frequent failures in TestWatchReplaceTargets with ‘Unmet: completed work "diagnosing files changed on disk"’ #50748

x/tools/gopls/internal/regtest/workspace: frequent failures in TestWatchReplaceTargets with ‘Unmet: completed work "diagnosing files changed on disk"’ #50748

Comments

bcmills commented Jan 21, 2022

bcmills commented Jan 21, 2022

gopherbot commented Jan 21, 2022

gopherbot commented May 22, 2023