-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: GC: unexpected fault address 0x0 #5074
Labels
Milestone
Comments
I tried writing a small reproducer, but I can't get it to fail. I'm not sure what triggers the failure. It only occurs when running through the whole msgpack.Decode benchmark. All tests pass, but running benchmark fails. The error occurs in the benchmark after the 92'th iteration i.e. for i := 0; i < b.N; i++ { log(">>>> i: %v", i) // <snip> } Only when i=92, then I get the error. So it seems to be an issue under some kind of load. Instead of waiting till I could create a small reproducer, I decided to file it hoping that something may jump out to folks familiar with the code. If running the benchmark directly will help, you can use the following steps to reproduce: git clone https://github.com/ugorji/go-msgpack . git checkout dev go test -bench '_Msgpack__Decode' You may not see the error on your first run. The second time you run it (and thereafter), you will. Note: The benchmark above depends on: vmsgpack "github.com/vmihailenco/msgpack" "launchpad.net/mgo/bson" You should 'go get' these libraries. Alternatively, you can edit the benchmark_test.go to remove references to bson and vmsgpack. |
ugorji: you should still provide the already edited version of benchmark_test.go that doesn't reference bson and vmsgpack in order to help debugging experience. I don't think anything jumps out: segfaults in new GC or runtime are common in late days and don't point out at anything in particular. |
possibly related, https://groups.google.com/d/msg/golang-nuts/R-d6yIMwUPE/WjOIshye8YQJ |
After a bisection session I obtained that: * It is buggy for a long time, at least since ~13 Feb. * For some reason network poller hid the problem: WORKS: 16202 a45e271add6c 2013-03-12 21:39 +0400 dvyukov runtime: fix build NOT WORKS: 16200 a364be6bc34f 2013-03-12 11:46 -0400 rsc encoding/xml: name space bug fixes (16201 does not build) * Then the problem reappeared as reported by ugorji: NOT WORKS: 16243 7bcfc5879223 2013-03-14 13:48 +0400 dvyukov runtime: revert UseSpanType back to 1 WORKS: 16241 5af2130aec77 2013-03-14 10:38 +0400 dvyukov runtime: integrated network poller for darwin (16242 does not build). The revisions that work are exactly those where UseSpanType = 0 in runtime.h (accidentally set by Dmitry when submitting runtime polling). |
Fix: https://golang.org/cl/7913043/ Please test. Status changed to WaitingForReply. |
This issue was closed by revision 54dffda. Status changed to Fixed. |
Doesn't seem to be fixed. See those failed linux/386 builds: http://build.golang.org/log/7576e9d5aa2c4ac8a29b2d4187e5883259fca5a8 http://build.golang.org/log/2f3402ee9cf50eca70723925ede1d0a888d53d74 linux/amd64: http://build.golang.org/log/fa5834a76f65e1a3a2564bc748f0487cf9166436 |
This issue was closed by revision bf1f461. Status changed to Fixed. |
Re comment #15, it is okay to check in multiple CLs with 'Fixes issue NNNN.' The issue tracker will attach them to the issue correctly, though of course only the first will change the status to Fixed. It is also okay to reopen the issue if you want a reminder that something needs fixing, but if you've already got the fix ready it's okay to skip that step and just mail the fix. Thanks. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: