You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mknyszek requested issue #50732 to be considered for backport to the next 1.16 minor release.
@gopherbot Please open backport issues for Go 1.16 and Go 1.17.
This issues is not really possible to workaround because downstream users are supposed to take the reported bucketing for runtime/metrics histograms at face value, and they're currently just wrong. The fix is also very small, and very safe.
The text was updated successfully, but these errors were encountered:
There was an off-by-one error in the time histogram buckets calculation
that caused the linear sub-buckets distances to be off by 2x.
The fix was trivial, but in writing tests I realized there was a much
simpler way to express the calculation for the histogram buckets, and
took the opportunity to do that here. The new bucket calculation also
fixes the bug.
For #50732.
Fixes#50733.
Change-Id: Idae89986de1c415ee4e148f778e0e101ca003ade
Reviewed-on: https://go-review.googlesource.com/c/go/+/380094
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 2e9dcb5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/384620
@mknyszek requested issue #50732 to be considered for backport to the next 1.16 minor release.
The text was updated successfully, but these errors were encountered: