Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings: typo in comment #50634

Closed
looshch opened this issue Jan 15, 2022 · 4 comments
Closed

strings: typo in comment #50634

looshch opened this issue Jan 15, 2022 · 4 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@looshch
Copy link
Contributor

looshch commented Jan 15, 2022

What version of Go are you using (go version)?

$ go version
1.17.5 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/hlushch/Library/Caches/go-build"
GOENV="/Users/hlushch/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/hlushch/Projects/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/hlushch/Projects/go/"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.17.5/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.17.5/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.17.5"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/nz/cqlmbdfs23schf6ndmr7gz440000gn/T/go-build2546855830=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Went to L20C51 in src/strings/builder.go

What did you expect to see?

No extra whitespace

What did you see instead?

Unneeded whitespace
@gopherbot
Copy link

Change https://golang.org/cl/378814 mentions this issue: strings: fix typo

@gopherbot
Copy link

Change https://golang.org/cl/378815 mentions this issue: strings: fix typo in comment

@seankhliao seankhliao added Documentation NeedsFix The path to resolution is known, but the work has not been done. labels Jan 16, 2022
@ianlancetaylor
Copy link
Contributor

Thanks. It's not necessary to open an issue for a typo if you are going to send a patch anyhow. Just send the patch. Thanks.

@looshch
Copy link
Contributor Author

looshch commented Jan 16, 2022

Got this, thank you.

@looshch looshch closed this as completed Jan 16, 2022
@dmitshur dmitshur added this to the Go1.18 milestone Feb 18, 2022
gopherbot pushed a commit that referenced this issue Feb 19, 2022
@looshch @dmitshur
strings: fix typo in comment
e002cf4 
Remove unnecessary whitespace in noescape comment

Fixes #50634

Change-Id: I1c8d16c020b05678577d349470fac7e7ab8a10b7
Reviewed-on: https://go-review.googlesource.com/c/go/+/378815
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
5 participants
@dmitshur @ianlancetaylor @gopherbot @seankhliao @looshch