New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: support debugCall on arm64 #50614
Comments
I'll take a look, assign it to me for now, if anyone makes a patch before me, feel free to submit it. Thanks. |
The issue is still open |
Is this definitely not going to be included in go1.18, or is there a small chance it might? |
I don't see any implementation yet, so it will definitely not be in Go 1.18. Sorry. |
No problem, thanks for confirming @ianlancetaylor. Hope this gets implemented and is released with Go 1.19. |
Change https://go.dev/cl/395754 mentions this issue: |
I have sent the PR, hope it will be merged into go1.19. |
That CL is only for linux/arm64, not for darwin/arm64, right? |
Yes, X86 also currently supports Linux only. |
Anyone planning to work on it for darwin/arm64? // @ianlancetaylor |
I'm not too familiar with |
AFAIK nothing. |
Let me rephrase: as far as I can see it should work on macOS/amd64 today. Is that not the case? If so, why doesn't it work? Thanks. |
I should have been less curt. As far as I know it works on macOS, today, as it is. It is not true that it is linux-only. |
Great, thanks. |
Sorry I just stared at the test, the test only supports Linux, but the implementation should not be limited to the system. |
Does Apple M1 (Pro, Max) will be supported? |
From the discussions above, yes. It should be covered. |
This issue is still not solved on the Latest Mac OS X version: Mac OSX: 12.3.1 (21E258) Darwin FVFGT4PMQ05N 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:47:26 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T8101 arm64 go version go1.18.1 darwin/arm64 Delve Debugger |
@ms140569 this issue is about implementing the runtime's side of call injection, which did happen. It will not work until delve's side is also implemented. |
Even if this is implemented, the changes won't be live until go1.19, right? Or is there a chance these could be included in a minor version? |
@gopherbot please open backports for Go 1.18 |
Backport issue(s) opened: #52699 (for 1.18). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
Sure, I'd happy to. |
debugCall is currently only supported on amd64, with the release of arm64 based macs it would be nice if a version of it also existed on arm64 and the feature has been requested on Delve's issue tracker: go-delve/delve#2277.
For example my message pointing out go1.18 will not support it received 25 sadfaces.
cc @heschi
The text was updated successfully, but these errors were encountered: