Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: TestPrctlRetInt failures with "unexpected return from prctl" on android-amd64-emu builder #50607

Closed
bcmills opened this issue Jan 14, 2022 · 1 comment
Closed

x/sys/unix: TestPrctlRetInt failures with "unexpected return from prctl" on android-amd64-emu builder #50607

bcmills opened this issue Jan 14, 2022 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 14, 2022 

--- FAIL: TestPrctlRetInt (0.00s)
    syscall_linux_test.go:827: unexpected return from prctl; got 0, expected 1
FAIL
exitcode=1
FAIL	golang.org/x/sys/unix	62.852s

greplogs --dashboard -md -l -e 'FAIL: TestPrctlRetInt'

2022-01-13T23:35:37-5a964db-e550c30/android-amd64-emu
2021-09-29T13:53:55-39ccf1d-e180e2c/android-amd64-emu

This is the test added in CL 209969 for #35978 (CC @tklauser @darkLord19).

From man prctl, it appears that the return value from PR_GET_NO_NEW_PRIVS depends on the state of the calling thread, so probably this test needs to be executed on a thread-locked goroutine.
@bcmills bcmills self-assigned this Jan 14, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jan 14, 2022
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. labels Jan 14, 2022
@bcmills bcmills modified the milestones: Unreleased, Go1.18 Jan 14, 2022
@gopherbot
Copy link

Change https://golang.org/cl/378555 mentions this issue: unix: lock the thread for TestPrctlRetInt

@rsc rsc unassigned bcmills Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@bcmills @gopherbot