Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/fuzz: test_fuzz_minimize_interesting failures with "cannot unmarshal empty string" #50606

Closed
bcmills opened this issue Jan 14, 2022 · 4 comments
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 14, 2022

go test proxy running at GOPROXY=http://127.0.0.1:54100/mod
--- FAIL: TestScript (0.01s)
    --- FAIL: TestScript/test_fuzz_minimize_interesting (3.78s)
        script_test.go:257: 
            # Test that when an interesting value is discovered (one that expands coverage),
            # the fuzzing engine minimizes it before writing it to the cache.
            #
            # The program below starts with a seed value of length 100, but more coverage
            # will be found for any value other than the seed. We should end with a value
            # in the cache of length 1 (the minimizer currently does not produce empty
            # strings). check_cache.go confirms that.
            #
            # We would like to verify that ALL values in the cache were minimized to a
            # length of 1, but this isn't always possible when new coverage is found in
            # functions called by testing or internal/fuzz in the background. (3.574s)
            > go test -c -fuzz=.  # Build using shared build cache for speed.
            > env GOCACHE=$WORK/gocache
            > exec ./fuzz.test$GOEXE -test.fuzzcachedir=$GOCACHE/fuzz -test.fuzz=FuzzMinCache -test.fuzztime=1000x
            [stdout]
            --- FAIL: FuzzMinCache (0.60s)
                cannot unmarshal empty string
            FAIL
            [stderr]
            fuzz: elapsed: 0s, gathering baseline coverage: 0/1 completed
            fuzz: elapsed: 0s, gathering baseline coverage: 1/1 completed, now fuzzing with 16 workers
            fuzz: elapsed: 1s, execs: 551 (1226/sec), new interesting: 4 (total: 4)
            [exit status 1]
            FAIL: testdata\script\test_fuzz_minimize_interesting.txt:18: unexpected command failure
            
FAIL
FAIL	cmd/go	277.000s

greplogs --dashboard -md -l -e '(?ms)FAIL: TestScript/test_fuzz_minimize_interesting.*cannot unmarshal empty string'

2022-01-13T20:43:56-6891d07/windows-amd64-longtest
2021-12-02T22:53:18-fd4b391/windows-arm64-10
2021-12-01T10:19:34-0e1d553/windows-arm64-10
2021-10-18T20:39:22-267abbe/windows-amd64-longtest
2021-09-30T18:10:18-205640e/windows-arm64-10
2021-09-29T16:45:42-2fad7db/windows-amd64-race

(attn @katiehockman @rolandshoemaker)

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker fuzz Issues related to native fuzzing support labels Jan 14, 2022
@bcmills bcmills added this to the Go1.18 milestone Jan 14, 2022
@toothrot
Copy link
Contributor

Pinging as this issue is a release blocker for Go 1.18. Any updates?

@katiehockman katiehockman self-assigned this Jan 19, 2022
@katiehockman
Copy link
Contributor

Thanks, I'll take a look at it this week.

@katiehockman
Copy link
Contributor

Just a side note: we thought we fixed this in #48721, but apparently not. It's also still only affecting Windows it seems.

@gopherbot
Copy link

Change https://golang.org/cl/360394 mentions this issue: internal/fuzz: centralize corpus entry addition

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Status: No status
Development

No branches or pull requests

4 participants