x/net/http2: TestServerDos_.* failures with "timeout waiting for frame" #50556

bcmills · 2022-01-11T20:35:00Z

(Pulled out from #34615 (comment), since the underlying cause may or may not be the same.)

--- FAIL: TestServerDoS_MaxHeaderListSize (2.27s)
    server_test.go:511: Error while expecting a HEADERS frame: timeout waiting for frame
    server_test.go:261: Framer read log:
        2022-01-11 11:07:02.018643035 Framer 0x40001300e0: read SETTINGS len=24, settings: MAX_FRAME_SIZE=1048576, MAX_CONCURRENT_STREAMS=250, MAX_HEADER_LIST_SIZE=1048896, INITIAL_WINDOW_SIZE=1048576
        2022-01-11 11:07:02.019169963 Framer 0x40001300e0: read SETTINGS flags=ACK len=0
        2022-01-11 11:07:02.019334467 Framer 0x40001300e0: read WINDOW_UPDATE len=4 (conn) incr=983041
    server_test.go:267: Framer write log:
        2022-01-11 11:07:02.012021141 Framer 0x40001300e0: wrote SETTINGS len=0
        2022-01-11 11:07:02.018771496 Framer 0x40001300e0: wrote SETTINGS flags=ACK len=0
        2022-01-11 11:07:02.019595556 Framer 0x40001300e0: wrote HEADERS flags=END_STREAM stream=1 len=4065
        2022-01-11 11:07:02.134889194 Framer 0x40001300e0: wrote CONTINUATION flags=END_HEADERS stream=1 len=1048576
FAIL
FAIL	golang.org/x/net/http2	73.247s

greplogs --dashboard -md -l -e '(?ms)FAIL: TestServerDoS[_ ].* timeout waiting for frame.*^FAIL\s+(?:golang.org/x/)net/http'

CC @neild @tombergan

The text was updated successfully, but these errors were encountered:

gopherbot · 2022-01-11T20:40:54Z

Change https://golang.org/cl/377814 mentions this issue: http2: eliminate arbitrary timeouts in readFrame methods

Certain slower builders empirically do not finish before these timeouts, and if a real deadlock should occur it would be more useful to let the test itself time out and get a goroutine dump anyway. Fixes golang/go#50556 Fixes golang/go#34615 Change-Id: I53ea616faa34f4ccc73af8eb18b794e12271b883 Reviewed-on: https://go-review.googlesource.com/c/net/+/377814 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Benny Siegert <bsiegert@gmail.com> Trust: Benny Siegert <bsiegert@gmail.com> Reviewed-by: Damien Neil <dneil@google.com>

bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 11, 2022

bcmills added this to the Go1.18 milestone Jan 11, 2022

bcmills self-assigned this Jan 11, 2022

bcmills added release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. labels Jan 12, 2022

gopherbot closed this as completed in golang/net@0dd24b2 Jan 14, 2022

rsc unassigned bcmills Jun 22, 2022

golang locked and limited conversation to collaborators Jun 22, 2023

gopherbot added the FrozenDueToAge label Jun 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/net/http2: TestServerDos_.* failures with "timeout waiting for frame" #50556

x/net/http2: TestServerDos_.* failures with "timeout waiting for frame" #50556

bcmills commented Jan 11, 2022

gopherbot commented Jan 11, 2022

x/net/http2: TestServerDos_.* failures with "timeout waiting for frame" #50556

x/net/http2: TestServerDos_.* failures with "timeout waiting for frame" #50556

Comments

bcmills commented Jan 11, 2022

gopherbot commented Jan 11, 2022