Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp: TestLSP/MultiModule and TestSource/MultiModule fail with "invalid argument" on plan9 #50478

Closed
bcmills opened this issue Jan 6, 2022 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9 Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2022

--- FAIL: TestLSP (39.13s)
    --- FAIL: TestLSP/MultiModule (6.19s)
        lsp_test.go:35: rename /tmp/TestLSP_MultiModule2211246401/lsp/go.mod testmodule/go.mod: invalid argument
FAIL
FAIL	golang.org/x/tools/internal/lsp	39.174s
…
--- FAIL: TestSource (47.65s)
    --- FAIL: TestSource/MultiModule (6.95s)
        source_test.go:36: rename /tmp/TestSource_MultiModule185591669/lsp/go.mod testmodule/go.mod: invalid argument
FAIL
FAIL	golang.org/x/tools/internal/lsp/source	54.205s

greplogs --dashboard -md -l -e 'FAIL: .*/MultiModule.*\n .* rename .*: invalid argument' --since=2021-01-01

2022-01-06T00:26:47-04daf88-b5bfaf4/plan9-386-0intro
2022-01-06T00:26:47-04daf88-b5bfaf4/plan9-amd64-0intro
2022-01-05T21:22:03-04daf88-2b39d86/plan9-386-0intro
2022-01-05T21:22:03-04daf88-2b39d86/plan9-amd64-0intro
2022-01-05T21:11:50-04daf88-88cafe0/plan9-386-0intro
2022-01-05T19:26:31-04daf88-002283e/plan9-386-0intro
2022-01-05T19:19:43-6606179-002283e/plan9-386-0intro
2022-01-05T16:44:50-15409b5-002283e/plan9-386-0intro
2022-01-05T09:50:29-15409b5-2c58bb2/plan9-386-0intro
2022-01-05T01:53:39-15409b5-301db3f/plan9-386-0intro
2022-01-04T22:27:20-15409b5-f154f8b/plan9-386-0intro
2022-01-04T22:05:15-15409b5-e39ab9b/plan9-386-0intro
2022-01-04T21:10:15-15409b5-1c8f9d2/plan9-386-0intro
2022-01-04T20:54:25-15409b5-95b240b/plan9-386-0intro
2022-01-04T19:51:13-72cd390-95b240b/plan9-386-0intro
2022-01-03T23:45:12-ee1ca4f-95b240b/plan9-386-0intro
2022-01-03T23:45:12-ee1ca4f-95b240b/plan9-amd64-0intro
2022-01-02T14:27:43-ee1ca4f-c886143/plan9-386-0intro
2022-01-02T14:27:43-ee1ca4f-c886143/plan9-amd64-0intro
2021-12-29T20:20:32-ee1ca4f-6178d25/plan9-386-0intro
2021-12-29T20:20:32-ee1ca4f-6178d25/plan9-amd64-0intro
2021-12-29T19:23:11-ee1ca4f-8a306e2/plan9-386-0intro
2021-12-29T19:23:11-ee1ca4f-8a306e2/plan9-amd64-0intro
2021-12-29T04:10:07-ee1ca4f-91e7821/plan9-386-0intro
2021-12-29T04:10:07-ee1ca4f-91e7821/plan9-amd64-0intro
2021-12-29T01:44:55-ee1ca4f-a78532a/plan9-386-0intro
2021-12-28T19:29:29-ee1ca4f-b357b05/plan9-386-0intro
2021-12-28T19:10:34-2c49d4f-b357b05/plan9-386-0intro
2021-12-23T20:03:38-8d38310-b357b05/plan9-386-0intro
2021-12-23T18:58:36-8d38310-af3b8cf/plan9-386-0intro
2021-12-23T17:27:50-8d38310-ed766b6/plan9-386-0intro
2021-12-22T23:31:40-8d38310-d2ce939/plan9-386-0intro
2021-12-22T20:47:09-8d38310-8cfcee1/plan9-386-0intro
2021-12-22T18:43:55-8d38310-0f3becf/plan9-386-0intro
2021-12-22T00:11:21-8d38310-90fb5a4/plan9-386-0intro
2021-12-21T23:09:59-8d38310-ebac50e/plan9-386-0intro
2021-12-17T00:14:53-8d38310-2e6e9df/plan9-386-0intro
2021-12-16T15:44:40-8d38310-1d3a5b4/plan9-386-0intro
2021-12-16T11:15:33-8d38310-7f23145/plan9-386-0intro
2021-12-16T00:34:10-c6ae451-7f23145/plan9-386-0intro
2021-12-15T16:50:15-c6ae451-b1c7703/plan9-386-0intro
2021-12-15T16:50:15-c6ae451-b1c7703/plan9-amd64-0intro
2021-12-15T16:03:37-cd2143c-b1c7703/plan9-386-0intro
2021-12-15T16:03:37-cd2143c-b1c7703/plan9-amd64-0intro
2021-12-15T14:48:19-27fc764-b1c7703/plan9-386-0intro
2021-12-15T14:48:19-27fc764-b1c7703/plan9-amd64-0intro
2021-12-15T13:31:58-27fc764-b5c0dba/plan9-386-0intro
2021-12-15T13:31:58-27fc764-b5c0dba/plan9-amd64-0intro
2021-12-15T00:33:55-27fc764-9d0ca26/plan9-386-0intro
2021-12-15T00:33:55-27fc764-9d0ca26/plan9-amd64-0intro
2021-12-14T23:20:01-27fc764-8108444/plan9-amd64-0intro
2021-12-14T22:42:47-27fc764-1540239/plan9-386-0intro
2021-12-14T22:42:47-27fc764-1540239/plan9-amd64-0intro
2021-12-14T21:23:43-27fc764-fc8ae98/plan9-386-0intro
2021-12-14T21:23:43-27fc764-fc8ae98/plan9-amd64-0intro
2021-12-14T20:25:03-27fc764-0f05ed3/plan9-386-0intro
2021-12-14T20:25:03-27fc764-0f05ed3/plan9-amd64-0intro
2021-12-14T19:53:20-27fc764-d407a8c/plan9-386-0intro
2021-12-14T19:10:22-27fc764-265fbaa/plan9-386-0intro
2021-12-14T19:10:22-27fc764-265fbaa/plan9-amd64-0intro
2021-12-14T17:43:51-27fc764-becaeea/plan9-386-0intro
2021-12-14T17:43:51-27fc764-becaeea/plan9-amd64-0intro
2021-12-14T17:22:06-27fc764-46ba32a/plan9-386-0intro
2021-12-14T16:19:51-27fc764-c1f012a/plan9-386-0intro
2021-12-14T01:48:22-27fc764-1afa432/plan9-386-0intro
2021-12-14T01:48:22-27fc764-1afa432/plan9-amd64-0intro
2021-12-13T22:45:26-27fc764-5b9207f/plan9-386-0intro
2021-12-13T22:45:26-27fc764-5b9207f/plan9-amd64-0intro
2021-12-13T21:29:11-27fc764-9e85dc5/plan9-386-0intro
2021-12-13T21:29:11-27fc764-9e85dc5/plan9-amd64-0intro
2021-12-13T19:40:29-27fc764-7bdbc73/plan9-386-0intro
2021-12-13T19:40:29-27fc764-7bdbc73/plan9-amd64-0intro
2021-12-13T16:44:13-27fc764-acc65b4/plan9-386-0intro
2021-12-13T16:44:13-27fc764-acc65b4/plan9-amd64-0intro
2021-12-13T16:09:22-27fc764-d198a36/plan9-386-0intro
2021-12-13T06:35:06-27fc764-9bfe09d/plan9-386-0intro
2021-12-13T06:35:06-27fc764-9bfe09d/plan9-amd64-0intro
2021-12-12T16:09:13-27fc764-49b7c9c/plan9-386-0intro
2021-12-12T16:09:13-27fc764-49b7c9c/plan9-amd64-0intro
2021-12-12T14:36:22-27fc764-5681704/plan9-386-0intro
2021-12-12T14:36:22-27fc764-5681704/plan9-amd64-0intro
2021-12-12T06:14:07-27fc764-9c6e8f6/plan9-386-0intro
2021-12-12T06:14:07-27fc764-9c6e8f6/plan9-amd64-0intro
2021-12-12T02:02:17-27fc764-1c1998e/plan9-386-0intro
2021-12-12T02:02:17-27fc764-1c1998e/plan9-amd64-0intro
2021-12-10T19:26:50-27fc764-766f89b/plan9-386-0intro
2021-12-10T19:26:50-27fc764-766f89b/plan9-amd64-0intro
2021-12-10T18:20:08-27fc764-c473ca0/plan9-386-0intro
2021-12-10T18:20:08-27fc764-c473ca0/plan9-amd64-0intro
2021-12-10T18:02:44-27fc764-13d15d1/plan9-386-0intro
2021-12-10T18:02:44-27fc764-13d15d1/plan9-amd64-0intro
2021-12-09T19:01:08-27fc764-8ff254e/plan9-386-0intro
2021-12-09T19:01:08-27fc764-8ff254e/plan9-amd64-0intro
2021-12-09T18:03:49-27fc764-ece493e/plan9-386-0intro
2021-12-09T18:03:49-27fc764-ece493e/plan9-amd64-0intro
2021-12-09T17:16:12-27fc764-78b4518/plan9-386-0intro
2021-12-09T16:59:48-27fc764-307d7c6/plan9-386-0intro
2021-12-09T15:47:16-27fc764-61ba0bc/plan9-386-0intro
2021-12-09T14:38:39-e06c107-61ba0bc/plan9-386-0intro
2021-12-09T13:40:01-e06c107-474ebb9/plan9-386-0intro
2021-12-08T23:38:20-3fca6a0-d6c4583/plan9-386-0intro
2021-12-08T23:38:20-3fca6a0-d6c4583/plan9-amd64-0intro
2021-12-08T23:00:01-3fca6a0-f5ddd94/plan9-386-0intro
2021-12-08T21:24:34-3fca6a0-bb9b20a/plan9-386-0intro
2021-12-08T21:24:34-3fca6a0-bb9b20a/plan9-amd64-0intro
2021-12-08T18:30:00-3fca6a0-61011de/plan9-386-0intro
2021-12-08T18:30:00-3fca6a0-61011de/plan9-amd64-0intro
2021-12-08T17:04:27-3fca6a0-c759ec2/plan9-386-0intro
2021-12-08T16:15:56-3fca6a0-46db6aa/plan9-386-0intro
2021-12-08T16:15:56-3fca6a0-46db6aa/plan9-amd64-0intro
2021-12-08T04:14:00-fd2bfb7-a19e72c/plan9-386-0intro
2021-12-08T04:14:00-fd2bfb7-a19e72c/plan9-amd64-0intro
2021-12-08T01:23:09-fd2bfb7-016e6eb/plan9-386-0intro
2021-12-08T01:23:09-fd2bfb7-016e6eb/plan9-amd64-0intro
2021-12-07T22:33:39-fd2bfb7-0a15e78/plan9-386-0intro
2021-12-07T22:33:39-fd2bfb7-0a15e78/plan9-amd64-0intro
2021-12-07T21:32:48-d3358c1-e08d1fb/plan9-386-0intro
2021-12-07T21:32:48-d3358c1-e08d1fb/plan9-amd64-0intro
2021-12-07T21:16:00-d3358c1-daf9018/plan9-386-0intro
2021-12-07T20:14:56-d3358c1-b37a539/plan9-386-0intro
2021-12-07T20:14:56-d3358c1-b37a539/plan9-amd64-0intro
2021-12-07T20:13:17-d3358c1-4300f10/plan9-amd64-0intro
2021-12-07T18:58:57-feb39d0-4300f10/plan9-386-0intro
2021-12-07T18:58:57-feb39d0-4300f10/plan9-amd64-0intro
2021-12-07T17:59:54-feb39d0-085d6ff/plan9-386-0intro
2021-12-07T03:44:02-feb39d0-dc65c48/plan9-386-0intro
2021-12-07T03:44:02-feb39d0-dc65c48/plan9-amd64-0intro
2021-12-03T22:57:02-c882a49-9ae0b35/plan9-386-0intro
2021-12-03T21:25:05-c882a49-d20a0bf/plan9-386-0intro
2021-12-03T18:55:11-c882a49-c4a8550/plan9-386-0intro
2021-12-03T18:55:02-f64c0f4-c4a8550/plan9-386-0intro
2021-12-03T18:27:20-e212aff-c4a8550/plan9-386-0intro
2021-12-01T06:03:27-1fd30d2-a412b5f/plan9-386-0intro
2021-11-30T22:42:17-1fd30d2-7ccbcc9/plan9-386-0intro
2021-11-30T20:04:58-2c9b078-7ccbcc9/plan9-386-0intro
2021-11-29T20:12:13-6e52f51-f598e29/plan9-386-0intro
2021-11-29T16:08:23-a618923-a59ab29/plan9-386-0intro
2021-11-29T15:05:11-a618923-1ea4d3b/plan9-386-0intro
2021-11-29T00:58:50-cb80a01-1ea4d3b/plan9-386-0intro
2021-11-27T23:29:50-cb80a01-0fa53e4/plan9-386-0intro
2021-11-27T19:49:32-cb80a01-a142d65/plan9-386-0intro
2021-11-27T01:14:21-cb80a01-fad67f8/plan9-386-0intro
2021-11-27T01:14:21-cb80a01-fad67f8/plan9-amd64-0intro
2021-11-23T21:59:51-7cf1f38-1ac45e0/plan9-386-0intro
2021-11-23T21:39:32-7cf1f38-e3eaedb/plan9-386-0intro
2021-11-23T19:31:05-7cf1f38-0f64c21/plan9-386-0intro
2021-11-23T18:15:15-7cf1f38-00045b7/plan9-386-0intro
2021-11-23T17:30:32-1e71a25-00045b7/plan9-386-0intro
2021-11-22T23:51:43-c2c92fd-83bfed9/plan9-386-0intro
2021-11-22T23:51:43-c2c92fd-83bfed9/plan9-amd64-0intro
2021-11-22T12:30:26-d0c7211-b2aa138/plan9-386-0intro
2021-11-20T01:00:16-d0c7211-be18cd5/plan9-386-0intro
2021-11-20T00:37:28-d0c7211-d2f4c93/plan9-386-0intro
2021-11-19T22:35:28-d0c7211-b31dda8/plan9-386-0intro
2021-11-19T21:59:14-d0c7211-5e774b0/plan9-386-0intro
2021-11-19T21:41:33-d0c7211-ba9f0f6/plan9-386-0intro
2021-11-19T19:11:45-d0c7211-ac0da79/plan9-386-0intro
2021-11-19T19:11:45-d0c7211-ac0da79/plan9-amd64-0intro
2021-11-18T20:11:45-43b469a-24898d6/plan9-386-0intro
2021-11-18T16:18:50-43b469a-feb330d/plan9-386-0intro
2021-11-18T02:53:02-43b469a-d8f7a64/plan9-386-0intro
2021-11-17T21:26:25-43b469a-0440fb8/plan9-386-0intro
2021-11-17T19:51:32-43b469a-9a33945/plan9-386-0intro
2021-11-17T19:16:04-43b469a-0981724/plan9-386-0intro
2021-11-08T14:49:56-0c60b7c-ab31dbc/plan9-386-0intro
2021-11-07T04:57:22-0c60b7c-9e6ad46/plan9-386-0intro
2021-11-04T17:07:48-84e69e7-5772877/plan9-386-0intro
2021-11-04T14:54:46-84e69e7-00d6d20/plan9-amd64-0intro
2021-11-04T07:05:31-84e69e7-2622235/plan9-386-0intro
2021-11-04T07:05:31-84e69e7-2622235/plan9-amd64-0intro
2021-10-26T18:33:39-244f92e-76cef81/plan9-386-0intro
2021-10-23T16:18:19-affba50-16318df/plan9-386-0intro
2021-10-16T14:50:21-98f6e03-680caf1/plan9-386-0intro
2021-10-10T15:11:26-1af23bd-d2d21d9/plan9-386-0intro
2021-10-04T17:17:11-ccaa907-cc5e3de/plan9-386-0intro
2021-09-24T19:46:09-939195f-cfd0868/plan9-386-0intro
2021-09-24T18:21:14-6d1e33f-f6b5ffb/plan9-386-0intro
2021-09-22T20:53:48-efaec4e-41bb744/plan9-386-0intro
2021-09-22T19:37:42-efaec4e-5b75a9b/plan9-386-0intro
2021-09-22T16:53:49-efaec4e-e128749/plan9-386-0intro
2021-09-09T09:06:46-076821b-b86e8dd/plan9-386-0intro
2021-09-02T19:56:24-3b801c8-065f380/plan9-386-0intro
2021-08-17T02:54:26-6932d22-29ec74f/plan9-386-0intro
2021-08-16T23:57:10-10bcabd-2a19333/plan9-386-0intro
2021-08-15T15:51:49-a55d515-48dfddb/plan9-386-0intro
2021-08-05T20:22:31-f367f01-fd45e26/plan9-386-0intro
2021-08-04T21:03:22-f367f01-6e73886/plan9-386-0intro
2021-07-29T15:30:38-ab1fe72-70fd4e4/plan9-386-0intro
2021-07-29T13:34:27-ab1fe72-9eee0ed/plan9-386-0intro
2021-07-28T20:09:10-07bc1bf-9eee0ed/plan9-386-0intro
2021-07-22T20:47:59-c740bfd-052da57/plan9-386-0intro
2021-07-16T02:43:48-6e9046b-aa4e0f5/plan9-386-0intro
2021-07-13T20:49:08-5061c41-a985897/plan9-386-0intro
2021-07-13T20:15:39-ef97713-a985897/plan9-386-0intro
2021-07-13T16:40:23-8e85a28-a985897/plan9-386-0intro
2021-07-02T16:25:10-7edcfe5-6125d0c/plan9-386-0intro
2021-07-02T16:14:50-7edcfe5-03761ed/plan9-386-0intro
2021-07-01T19:09:57-20dafe5-03761ed/plan9-386-0intro
2021-06-27T05:06:30-12f8456-c95464f/plan9-386-0intro
2021-06-25T23:53:21-12f8456-ed01cea/plan9-386-0intro
2021-06-24T00:39:41-d824a74-73496e0/plan9-386-0intro
2021-06-23T15:16:55-d824a74-0ebd5a8/plan9-386-0intro
2021-06-17T14:53:37-463a76b-4dede02/plan9-386-0intro
2021-06-17T04:32:50-463a76b-97cee43/plan9-386-0intro
2021-06-11T17:18:39-4b484fb-e2dc6dd/plan9-386-0intro
2021-06-11T15:30:39-490eac8-2f11284/plan9-386-0intro
2021-06-08T22:35:56-4e58f8f-bcecae2/plan9-386-0intro
2021-06-08T20:45:46-4e58f8f-6551763/plan9-386-0intro
2021-06-04T17:45:44-7295a4e-831f937/plan9-386-0intro
2021-06-04T17:45:44-7295a4e-831f937/plan9-amd64-0intro
2021-05-30T17:47:50-6123e5f-3b770f2/plan9-386-0intro
2021-05-26T23:33:38-a3eb095-3075ffc/plan9-386-0intro
2021-05-26T22:54:09-a3eb095-a62c087/plan9-386-0intro
2021-05-20T20:37:02-2275bb5-baa934d/plan9-386-0intro
2021-05-20T18:25:17-2275bb5-7c692cc/plan9-386-0intro
2021-05-20T17:40:58-3063790-7c692cc/plan9-386-0intro
2021-05-15T02:39:08-09ab05b-ce92a20/plan9-386-0intro
2021-05-11T03:28:22-18795da-326a792/plan9-386-0intro
2021-05-10T19:19:34-ecb7392-dc50683/plan9-386-0intro
2021-05-06T20:30:00-c0140e8-4dbad79/plan9-386-0intro
2021-05-04T21:16:16-f03daea-cd28ca3/plan9-386-0intro
2021-05-04T19:12:24-f03daea-8c3d217/plan9-386-0intro
2021-05-03T01:35:44-7a6108e-2c9f5a1/plan9-386-0intro
2021-05-02T20:59:26-7a6108e-bb09f8a/plan9-386-0intro
2021-05-02T18:22:19-7a6108e-0d32d9e/plan9-386-0intro
2021-05-01T19:17:47-7a6108e-053fe2f/plan9-386-0intro
2021-04-29T11:37:05-800adbe-c4c68fb/plan9-386-0intro
2021-04-29T04:59:52-800adbe-6afa0ae/plan9-386-0intro
2021-04-27T22:46:28-7c72a84-983dea9/plan9-386-0intro
2021-04-27T20:55:22-7c72a84-b9dfaf7/plan9-386-0intro
2021-04-27T19:53:45-d0768c9-b9dfaf7/plan9-386-0intro
2021-04-21T16:46:52-e74674a-35806ef/plan9-386-0intro
2021-04-21T16:26:01-e74674a-b8a359d/plan9-386-0intro
2021-04-20T17:53:17-dbc8747-109d758/plan9-386-0intro
2021-04-20T16:44:18-a13dbf1-109d758/plan9-386-0intro
2021-04-20T02:42:23-10909d8-fe26dfa/plan9-386-0intro
2021-04-18T17:40:12-07295ca-4efd581/plan9-386-0intro
2021-04-17T00:02:01-07295ca-fd3612e/plan9-386-0intro
2021-04-14T16:59:24-2140cce-4480c82/plan9-386-0intro
2021-04-14T15:02:11-2140cce-c98026c/plan9-386-0intro
2021-04-12T02:29:32-ec686a2-7beb988/plan9-386-0intro
2021-04-11T15:56:20-ec686a2-189c694/plan9-386-0intro
2021-04-10T19:02:08-ec686a2-3f4977b/plan9-386-0intro
2021-04-06T21:43:19-c602466-0a51047/plan9-386-0intro
2021-04-06T20:28:21-c602466-b56177a/plan9-386-0intro
2021-04-05T22:17:18-11c3f83-79b2e14/plan9-386-0intro
2021-04-05T20:53:42-8c34cc9-79b2e14/plan9-386-0intro
2021-04-04T20:04:37-8c34cc9-4230a6e/plan9-386-0intro
2021-03-26T06:03:20-63ea654-98a9023/plan9-386-0intro
2021-03-24T19:18:50-52cb772-fef5a15/plan9-386-0intro
2021-03-24T18:15:38-52cb772-771c57e/plan9-386-0intro
2021-03-24T17:17:31-a1191f3-fd5e0bd/plan9-386-0intro
2021-03-19T14:27:48-1aac171-196b104/plan9-386-0intro
2021-03-19T04:40:15-1aac171-ed3ae9a/plan9-386-0intro

CC @findleyr @0intro @fhs @millerresearch

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 6, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Jan 6, 2022

I'm not sure exactly what's going on here. I suspect that the failing rename is this one:
https://cs.opensource.google/go/x/tools/+/master:internal/lsp/tests/tests.go;l=501;drc=0cffec9e30d002e3af58010197795a3e089688b5

However, as far as I can tell both arguments to that os.Rename should be absolute — the error message from the builder seems to list one of them as relative.

As with #50477, I plan to add a skip without investigating further.

@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jan 6, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jan 6, 2022
@bcmills bcmills added OS-Plan9 NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 6, 2022
@bcmills bcmills modified the milestones: Unreleased, gopls/unplanned Jan 6, 2022
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/375876 mentions this issue: x/tools/gopls/internal/regtest/modfile: skip TestUnknownRevision and MultiModule tests on plan9

@millerresearch
Copy link
Contributor

However, as far as I can tell both arguments to that os.Rename should be absolute — the error message from the builder seems to list one of them as relative.

os.Rename in Plan 9 modifies the new name, removing the leading part of the path if it matches the directory of the old name, before reporting that particular error, so the message is a bit misleading.

What's happening is that the test is trying to rename $dir/go.mod to $dir/testmodule/go.mod, where dir=/tmp/TestLSP_MultiModule2211246401/lsp -- but that's illegal because Plan 9 doesn't allow renames across directories.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/376115 mentions this issue: internal/lsp/tests: re-enable MultiModule tests on plan9

gopherbot pushed a commit to golang/tools that referenced this issue Jan 7, 2022
…MultiModule tests on plan9

For golang/go#50477
For golang/go#50478

Change-Id: If2a9d175c06446db70628a21a1552e32239627c1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/375876
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@golang golang locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9 Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants