Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review: TestSyncRebase failures with "hint: use --reapply-cherry-picks" since 2021-12-22 #50453

Closed
bcmills opened this issue Jan 5, 2022 · 5 comments
Closed

x/review: TestSyncRebase failures with "hint: use --reapply-cherry-picks" since 2021-12-22 #50453

bcmills opened this issue Jan 5, 2022 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 5, 2022 •
edited 

--- FAIL: TestSyncRebase (0.35s)
    sync_test.go:70: git-codereview sync
    sync_test.go:88: git-codereview sync
    sync_test.go:88: stderr:
        hint: use --reapply-cherry-picks to include skipped commits
        hint: Disable this message with "git config advice.skippedCherryPicks false"
    sync_test.go:90: unexpected stderr:
        hint: use --reapply-cherry-picks to include skipped commits
        hint: Disable this message with "git config advice.skippedCherryPicks false"
FAIL
FAIL	golang.org/x/review/git-codereview	25.652s

greplogs --dashboard -md -l -e 'hint: use --reapply-cherry-picks' --since=2021-06-01

2022-01-05T09:50:29-b8ead20-2c58bb2/freebsd-386-13_0
2022-01-05T09:50:29-b8ead20-2c58bb2/freebsd-amd64-13_0
2022-01-05T09:50:29-b8ead20-2c58bb2/freebsd-amd64-race
2022-01-05T01:53:39-b8ead20-301db3f/freebsd-386-13_0
2022-01-05T01:53:39-b8ead20-301db3f/freebsd-amd64-13_0
2022-01-05T01:53:39-b8ead20-301db3f/freebsd-amd64-race
2022-01-04T22:27:20-b8ead20-f154f8b/freebsd-386-13_0
2022-01-04T22:27:20-b8ead20-f154f8b/freebsd-amd64-13_0
2022-01-04T22:27:20-b8ead20-f154f8b/freebsd-amd64-race
2022-01-04T22:05:15-b8ead20-e39ab9b/freebsd-386-13_0
2022-01-04T22:05:15-b8ead20-e39ab9b/freebsd-amd64-13_0
2022-01-04T22:05:15-b8ead20-e39ab9b/freebsd-amd64-race
2022-01-04T21:10:15-b8ead20-1c8f9d2/freebsd-386-13_0
2022-01-04T21:10:15-b8ead20-1c8f9d2/freebsd-amd64-13_0
2022-01-04T21:10:15-b8ead20-1c8f9d2/freebsd-amd64-race
2021-12-22T22:05:22-b8ead20-1242f43/freebsd-386-13_0
2021-12-22T22:05:22-b8ead20-1242f43/freebsd-amd64-13_0
2021-12-22T22:05:22-b8ead20-1242f43/freebsd-amd64-race
2021-12-22T22:05:01-b8ead20-169be8e/freebsd-386-13_0
2021-12-22T22:05:01-b8ead20-169be8e/freebsd-amd64-13_0
2021-12-22T22:05:01-b8ead20-169be8e/freebsd-amd64-race

CC @r5d
@gopherbot gopherbot added this to the Unreleased milestone Jan 5, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Jan 5, 2022 •
edited

This is a release-blocker via #11811. It appears to be a regression at commit b8ead20.

@bcmills bcmills modified the milestones: Unreleased, Go1.18 Jan 5, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Jan 5, 2022

Actually, looking at the builders this seems to be a regression specifically in the freebsd-*-13_0 builders (CC @heschi)

@bcmills
Copy link
Contributor Author

bcmills commented Jan 5, 2022 •
edited

I'm also seeing the same failure mode locally with git version 2.34.1.448.ga2b2bfdf31-goog on linux/amd64.

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 5, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Jan 5, 2022

(Also noted in #42926 (comment).)

@bcmills bcmills changed the title x/review: failures with "hint: use --reapply-cherry-picks" since 2021-12-22 x/review: TestSyncRebase failures with "hint: use --reapply-cherry-picks" since 2021-12-22 Jan 5, 2022
@gopherbot
Copy link

Change https://golang.org/cl/376039 mentions this issue: x/review: fix TestSyncRebase test

@heschi heschi assigned heschi and unassigned heschi Jan 7, 2022
@golang golang locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @heschi