Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: pkg.go.dev/net/http #50377

Closed
InfoLibre opened this issue Dec 28, 2021 · 1 comment
Closed

x/pkgsite: pkg.go.dev/net/http #50377

InfoLibre opened this issue Dec 28, 2021 · 1 comment

Comments

@InfoLibre
Copy link

InfoLibre commented Dec 28, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/net/http#DetectContentType

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:95.0) Gecko/20100101 Firefox/95.0

What did you do?

I used http.DetectContentType with this uploaded LibreOffice files.

buff, err := file.Open()
head := make([]byte, 512)
_, err = buff.Read(head)
contentType = http.DetectContentType(head)

What did you expect to see?

LibreOffice Files MIME type.

What did you see instead?

Zip MIME type.

Could you add OpenDocument MIME type to http.DetectContentType, like https://github.com/gabriel-vasile/mimetype do?

@gopherbot gopherbot added this to the pkgsite/unplanned milestone Dec 28, 2021
@ALTree
Copy link
Member

ALTree commented Dec 28, 2021

As documented, DetectContentType follows https://mimesniff.spec.whatwg.org/, which does not define a Libreoffice file signature.

@ALTree ALTree closed this as completed Dec 28, 2021
@golang golang locked and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants