Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: do not name temp directories using import paths #5027

Closed
rsc opened this issue Mar 11, 2013 · 11 comments
Closed

cmd/go: do not name temp directories using import paths #5027

rsc opened this issue Mar 11, 2013 · 11 comments

Comments

@rsc
Copy link
Contributor

rsc commented Mar 11, 2013

Naming the temp work directories using import paths means that if you're building
x/y/z/w you end up working in /tmp/garbage/x/y/z/w and then you need to put compiled
packages somewhere during a test so you end up with
/tmp/garbage/x/y/z/w/_test/x/y/z/w.a. If the path is long, the doubling here can exceed
OS limits, especially on Windows where the limit is 250 bytes. 

We can shuffle things a little in the go command so that the import path need never
appear twice in the temporary path. That will buy us a little space.

A better fix is to use the \\?\ syntax on Windows to get longer path names, but that fix
is fraught with peril and too dangerous for Go 1.1. That's issue #3358.
@rsc
Copy link
Contributor Author

rsc commented Mar 11, 2013

Comment 1:

Labels changed: added priority-later, removed priority-triage.

@rsc
Copy link
Contributor Author

rsc commented Mar 12, 2013

Comment 2:

Labels changed: added go1.1maybe, removed go1.1.

@robpike
Copy link
Contributor

robpike commented May 18, 2013

Comment 3:

Labels changed: added go1.2maybe, removed go1.1maybe.

@rsc
Copy link
Contributor Author

rsc commented Jul 30, 2013

Comment 4:

Labels changed: added feature.

@robpike
Copy link
Contributor

robpike commented Aug 29, 2013

Comment 5:

Not for 1.2.

Labels changed: removed go1.2maybe.

@rsc
Copy link
Contributor Author

rsc commented Nov 27, 2013

Comment 6:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Nov 27, 2013

Comment 7:

Labels changed: removed feature.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 8:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 9:

Labels changed: added repo-main.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc
Copy link
Contributor Author

rsc commented Nov 2, 2017

Fixed by ee4fbbc.

@rsc rsc closed this as completed Nov 2, 2017
@robpike
Copy link
Contributor

robpike commented Nov 2, 2017

Wondering what the lowest issue number is that this burst will close.

@golang golang locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants