Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: Effective Go: Visible anchors for linkable sections #50211

Open
Deleplace opened this issue Dec 16, 2021 · 2 comments
Open

x/website: Effective Go: Visible anchors for linkable sections #50211

Deleplace opened this issue Dec 16, 2021 · 2 comments
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. website

Comments

@Deleplace
Copy link
Contributor

What is the URL of the page with the issue?

https://go.dev/doc/effective_go

Screenshot

image

What did you do?

I wanted to create a direct hyperlink to the section Type switch and add it to a webpage in another Go-related website.

What did you expect to see?

Feature request: all the section headings (h2, h3) would come with a trailing ¶ as a visual indicator for "Click here to get the direct URL to this section". Optionally, the ¶ char only shows up when the mouse approaches the heading. (All of this is the existing behaviour in all package pages at pkg.go.dev)

image

What did you see instead?

  • Section headings are not hyperlinks.
  • All of the h2, h3 already have an id attribute (this is great).
  • All of the h2, h3 already have a corresponding link inside the Table of Contents.
  • I had to search in the Table of Contents in order to click the "Type switch" and retrieve the relevant URL with the proper anchor.
@gopherbot gopherbot added this to the Unreleased milestone Dec 16, 2021
@Deleplace
Copy link
Contributor Author

This is like #50210, but milder, as all the relevant section URLs are already there, in the ToC.

@cherrymui cherrymui added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Dec 16, 2021
@cherrymui
Copy link
Member

cc @dmitshur

@jamalc jamalc modified the milestones: Unreleased, website/later Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. website
Projects
None yet
Development

No branches or pull requests

4 participants