Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: uses too much GitHub quota #50197

Open
heschi opened this issue Dec 15, 2021 · 1 comment
Open

x/build/cmd/gerritbot: uses too much GitHub quota #50197

heschi opened this issue Dec 15, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release Team
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Dec 15, 2021

gerritbot makes GitHub API requests for each open PR. There are enough open PRs across all the Go repositories that each gerritbot restart consumes most (maybe all?) of our 5000 requests per hour.

In response, today I closed all the PRs that were opened more than a year ago. This has had the effect of annoying a number of people and probably is not a tenable plan long-term. It seems we'll have to figure out a way to avoid looking at unmodified PRs that works across restarts.
@heschi heschi added this to the Unreleased milestone Dec 15, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 15, 2021
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 15, 2021
This was referenced Dec 15, 2021
Open
Open
Open
Closed
Closed
@ianlancetaylor ianlancetaylor mentioned this issue Dec 16, 2021
Open
@heschi heschi mentioned this issue Dec 16, 2021
Open
@mvdan
Copy link
Member

mvdan commented Dec 29, 2021 •
edited

Perhaps related: gerritbot could automatically close PRs fixing proposal issues that have been declined. That is, the issue is closed, has the Proposal label, but not the Proposal-Accepted label.

I found one manually right now (#48267); I'm sure there are at least a handful of others right now, at least. The authors rarely close the PRs themselves, and auto-closing these shouldn't be too hard in terms of code logic.

Edit: also #47640 and #48015. I'm stopping the manual search here for now :)

@cagedmantis cagedmantis added this to Planned in Go Release Team Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Status: Planned
Go Release Team
Planned
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mvdan @gopherbot @cherrymui @heschi