Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: documentation for builtins is not working #50196

Closed
hyangah opened this issue Dec 15, 2021 · 3 comments
Closed

x/tools/gopls: documentation for builtins is not working #50196

hyangah opened this issue Dec 15, 2021 · 3 comments
Labels
Documentation FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Dec 15, 2021

go version recognized by gopls

(go version go version go1.18beta1 darwin/amd64)
(valid build configuration = false)
(build flags: [])
...
GOROOT=/Users/hakim/sdk/go1.18beta1

gopls version: v0.7.4

Screen Shot 2021-12-15 at 10 36 36 AM

Verified the problem exists with gopls v0.7.3 + go 1.17.5.
Go to definition works correctly.

@findleyr currently guesses this is related to AST trimming.

@hyangah hyangah added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 15, 2021
@findleyr findleyr added this to the gopls/v0.7.5 milestone Dec 15, 2021
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. Documentation labels Dec 15, 2021
@findleyr findleyr modified the milestones: gopls/v0.7.5, gopls/v0.8.0 Jan 5, 2022
@gopherbot
Copy link

Change https://golang.org/cl/383614 mentions this issue: internal/lsp/source: provide full documentation of builtin types

@fzipp
Copy link
Contributor

fzipp commented Feb 6, 2022

Here an image that shows before and after CL 383614:

issue-50196-before-after

@findleyr
Copy link
Contributor

findleyr commented Feb 7, 2022

@fzipp thanks for the CL!

@golang golang locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants