Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: links in header/footer of tip.golang.org should redirect to pkgsite at tip #50180

Open
ahmetb opened this issue Dec 15, 2021 · 2 comments
Open

x/website: links in header/footer of tip.golang.org should redirect to pkgsite at tip #50180

ahmetb opened this issue Dec 15, 2021 · 2 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ahmetb
Copy link

ahmetb commented Dec 15, 2021 •
edited

It seems that with the shift towards pkgsite (pkg.go.dev), now clicking on the https://tip.golang.org > "Packages" link does not make it possible to browse the stdlib packages in "tip" (since it just sends the user to the https://pkg.go.dev/ homepage, which has no indication of "tip" that the user can easily find.)

This wasn't always the case: http://web.archive.org/web/20190318200504/https://tip.golang.org/pkg/ In the past, clicking Packages from the navbar showed the visitor package documentation from the tip.

Proposal: clicking on Packages from the navbar on tip.golang.org should send the user to a page where they can browse the packages at the tip, such as https://pkg.go.dev/@master but that does not work, I think (although the @master suffix for the URL works if the rest of the URL is a valid package name).
@gopherbot gopherbot added this to the Unreleased milestone Dec 15, 2021
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 15, 2021
@cherrymui
Copy link
Member

cc @dmitshur @rsc

@dmitshur
Copy link
Contributor

This was done in other cases, for example https://tip.golang.org/pkg redirects to https://pkg.go.dev/std@master. Looks like this is an edge case that was missed, and just needs to be fixed. Thanks for reporting.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 15, 2021
@dmitshur dmitshur changed the title x/website: tip.golang.org should redirect to pkgsite with tip link x/website: links in header/footer of tip.golang.org should redirect to pkgsite at tip Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@ahmetb @dmitshur @gopherbot @cherrymui