Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: error parsing large ASN.1 identifiers [1.17 backport] #50165

Closed
gopherbot opened this issue Dec 14, 2021 · 3 comments
Closed

crypto/x509: error parsing large ASN.1 identifiers [1.17 backport] #50165

gopherbot opened this issue Dec 14, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.6

Comments

@gopherbot
Copy link

@FiloSottile requested issue #49678 to be considered for backport to the next 1.17 minor release.

@gopherbot please open a backport issue to Go 1.17. This is a regression due to Go 1.17 changes without workaround that makes it impossible to parse some valid (if a little weird) certificates.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 14, 2021
@gopherbot gopherbot mentioned this issue Dec 14, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.6 milestone Dec 14, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/372274 mentions this issue: [internal-branch.go1.17-vendor] cryptobyte: fix parsing of large ASN.1 OIDs

gopherbot pushed a commit to golang/crypto that referenced this issue Dec 15, 2021
@umlublin @FiloSottile
[internal-branch.go1.17-vendor] cryptobyte: fix parsing of large ASN.…
cf75a17 
…1 OIDs

Updates golang/go#49678
For golang/go#50165

Change-Id: If8a40e25edd810a66165ab78dd68d9b7fc2699f8
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/365674
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Trust: Alex Rakoczy <alex@golang.org>
Trust: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit e495a2d)
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/372274
Trust: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Dec 15, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 15, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/373361 mentions this issue: [release-branch.go1.17] all: update vendored golang.org/x/crypto for cryptobyte fix

@gopherbot
Copy link
Author

Closed by merging 4223f6e to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Dec 21, 2021
@FiloSottile @dmitshur
[release-branch.go1.17] all: update vendored golang.org/x/crypto for …
4223f6e 
…cryptobyte fix

Updates #49678
Fixes #50165

Change-Id: I47dd959a787180a67856e60dfa6eba3ddd045972
Reviewed-on: https://go-review.googlesource.com/c/go/+/373361
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.6
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui