Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows: TestProcThreadAttributeHandleList failing with "The parameter is incorrect." on release-branch.go1.16 #50160

Closed
bcmills opened this issue Dec 14, 2021 · 3 comments
Closed

x/sys/windows: TestProcThreadAttributeHandleList failing with "The parameter is incorrect." on release-branch.go1.16 #50160

bcmills opened this issue Dec 14, 2021 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16.13

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 14, 2021 •
edited 

--- FAIL: TestProcThreadAttributeHandleList (0.00s)
    syscall_windows_test.go:1047: The parameter is incorrect.
FAIL
FAIL	golang.org/x/sys/windows	1.629s

greplogs --dashboard -md -l -e 'FAIL: TestProcThreadAttributeHandleList' --since=2021-12-01

2021-12-13T22:30:07-03aa0b5-f1f3923/windows-386-2008
2021-12-13T22:30:07-03aa0b5-f1f3923/windows-amd64-2016
2021-12-13T22:30:07-03aa0b5-f1f3923/windows-amd64-race
@gopherbot gopherbot added this to the Unreleased milestone Dec 14, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.16.13 Dec 14, 2021
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Dec 14, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Dec 14, 2021

This is a release-blocker for the next Go 1.16 minor release via #11811.
The failing test was added in CL 371276.

It can be addressed by either fixing x/sys to work with Go 1.16, or backporting fixes to Go 1.16 to fix the failing test.

CC @zx2c4 @bufflig @golang/release.

@bcmills bcmills changed the title x/sys/windows: TestProcThreadAttributeHandleList failing on release-branch.go1.16 x/sys/windows: TestProcThreadAttributeHandleList failing with "The parameter is incorrect." on release-branch.go1.16 Dec 14, 2021
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows labels Dec 14, 2021
@gopherbot gopherbot removed the NeedsFix The path to resolution is known, but the work has not been done. label Dec 14, 2021
@gopherbot
Copy link

Change https://golang.org/cl/371694 mentions this issue: windows: set pipe explicitly inheritable in test for go 1.16

@zx2c4
Copy link
Contributor

zx2c4 commented Dec 14, 2021

Fixed with https://golang.org/cl/371694. Sorry about that.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 6, 2022
@golang golang locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16.13
Development

No branches or pull requests
4 participants
@zx2c4 @dmitshur @bcmills @gopherbot