x/benchmarks/sweet/benchmarks/internal/pool: failures with "expected error from bad worker" #50096
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
okay-after-beta1
Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1
release-blocker
Milestone
greplogs --dashboard -md -l -e 'FAIL: TestPoolError .*\n .*expected error from bad worker'
2021-12-10T19:26:50-df0ca34-766f89b/linux-amd64-race
2021-12-02T18:28:30-2890d99-c5c1955/freebsd-amd64-13_0
This test was added in CL 368195 (CC @mknyszek, @dr2chase, @prattmic).
It looks like this is reporting a real bug in the
internal/pool
package, probably here:https://cs.opensource.google/go/x/benchmarks/+/master:sweet/benchmarks/internal/pool/pool.go;l=126-135;drc=940a5193d97ee097a93c26c7123d691304e5e3f4
This sort of completion-vs-error race (and the associated cancellation pattern) is pretty much exactly the one that the
errgroup
package was designed to address. I would recommend using that here.The text was updated successfully, but these errors were encountered: