Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/internal/wycheproof: test timeouts on linux-amd64-wsl builder #50076

Closed
bcmills opened this issue Dec 9, 2021 · 1 comment
Closed

x/crypto/internal/wycheproof: test timeouts on linux-amd64-wsl builder #50076

bcmills opened this issue Dec 9, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 9, 2021

greplogs --dashboard -md -l -e ^SIGQUIT.\*\\n\(\?:.\*\\n\)\*FAIL\\s+golang\\.org/x/crypto/internal/wycheproof

2021-12-09T13:44:57-5770296-f1f3923/linux-amd64-wsl
2021-10-18T16:06:08-089bfa5-417100e/linux-amd64-wsl
2021-10-16T16:27:40-089bfa5-640a49b/linux-amd64-wsl
2021-10-13T15:12:46-089bfa5-f687831/linux-amd64-wsl
2021-10-06T19:44:11-089bfa5-9062a52/linux-amd64-wsl

(CC @mengzhuo for linux-amd64-wsl; @FiloSottile, @katiehockman, @rolandshoemaker for x/crypto.)

The hangs seem to be in the go mod download step during test setup. The linux-amd64-wsl builder has a particularly unreliable network connection, so I suspect that's related.
@bcmills bcmills added the Builders x/build issues (builders, bots, dashboards) label Dec 9, 2021
@bcmills bcmills added this to the Go1.18 milestone Dec 9, 2021
@gopherbot
Copy link

Change https://golang.org/cl/370659 mentions this issue: internal/wycheproof: skip on builders with flaky network connections

@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Dec 9, 2021
owenthereal pushed a commit to owenthereal/upterm.crypto that referenced this issue Mar 5, 2022
@owenthereal
internal/wycheproof: skip on builders with flaky network connections
fa4a6cb 
This test downloads JSON test files from GitHub. If the network
connection flakes, the test may hang indefinitely, and builders with
flaky network connections might want to avoid unnecessary downloading
anyway.

Fixes golang/go#50076

Change-Id: I0655a34fce8a003794290c0c82ae75492eda4429
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/370659
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
iamacarpet pushed a commit to affordablemobiles/xcrypto that referenced this issue Aug 2, 2022
@iamacarpet
internal/wycheproof: skip on builders with flaky network connections
4f245bb 
This test downloads JSON test files from GitHub. If the network
connection flakes, the test may hang indefinitely, and builders with
flaky network connections might want to avoid unnecessary downloading
anyway.

Fixes golang/go#50076

Change-Id: I0655a34fce8a003794290c0c82ae75492eda4429
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/370659
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Dec 9, 2022
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
internal/wycheproof: skip on builders with flaky network connections
ab5e98c 
This test downloads JSON test files from GitHub. If the network
connection flakes, the test may hang indefinitely, and builders with
flaky network connections might want to avoid unnecessary downloading
anyway.

Fixes golang/go#50076

Change-Id: I0655a34fce8a003794290c0c82ae75492eda4429
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/370659
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
internal/wycheproof: skip on builders with flaky network connections
2ead909 
This test downloads JSON test files from GitHub. If the network
connection flakes, the test may hang indefinitely, and builders with
flaky network connections might want to avoid unnecessary downloading
anyway.

Fixes golang/go#50076

Change-Id: I0655a34fce8a003794290c0c82ae75492eda4429
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/370659
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
2 participants
@bcmills @gopherbot