Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc/jsonrpc: client nil pointer deference on invalid reply #5006

Closed
gopherbot opened this issue Mar 8, 2013 · 4 comments
Closed

net/rpc/jsonrpc: client nil pointer deference on invalid reply #5006

gopherbot opened this issue Mar 8, 2013 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.1

Comments

@gopherbot
Copy link

by nos.adrian:

Returning invalid data to the client can result in a nil pointer deference:

http://play.golang.org/p/FAGJ4upO4Z

Unit test & proposed fix attached.

Attachments:

  1. jsonrpc.patch (1600 bytes)
@ianlancetaylor
Copy link
Contributor

Comment 1:

Labels changed: added go1.1maybe.

@robpike
Copy link
Contributor

robpike commented Mar 8, 2013

Comment 2:

Thanks. Fix looks right to me.
You are not on the official Go contributors list. The fix is tiny so I'm happy to make
it myself if you want to avoid the minor bureaucracy that entails, or you can go through
the official channels by following the instructions at
http://golang.org/doc/contribute.html
Please advise.

Labels changed: added priority-later, go1.1, removed priority-triage, go1.1maybe.

Status changed to WaitingForReply.

@gopherbot
Copy link
Author

Comment 3 by nos.adrian:

I think I managed all the steps required. issue #7691045 should be available for review.

@rsc
Copy link
Contributor

rsc commented Mar 12, 2013

Comment 4:

This issue was closed by revision 0d559f7.

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
4 participants
@rsc @ianlancetaylor @robpike @gopherbot