Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/gorename: failures with "Building gorename: exit status 2" #50043

Closed
bcmills opened this issue Dec 8, 2021 · 2 comments
Closed

x/tools/cmd/gorename: failures with "Building gorename: exit status 2" #50043

bcmills opened this issue Dec 8, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 8, 2021

greplogs --dashboard -md -l -e 'FAIL: TestGeneratedFiles.*\n gorename_test\.go:\d+: Building gorename: '

2021-12-07T17:46:04-feb39d0-4c943ab/freebsd-amd64-13_0
2021-12-03T18:55:02-f64c0f4-98ef91b/netbsd-amd64-9_0-n2d
2021-12-01T18:47:44-3c63f30-f6103e9/netbsd-386-9_0-n2d

At the very least, this test needs to log stderr and stdout of the failing process so that we can figure out what is going wrong.
(https://golang.org/wiki/CodeReviewComments#useful-test-failures)
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 8, 2021
@bcmills bcmills added this to the Backlog milestone Dec 8, 2021
@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 8, 2021
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 8, 2021
@gopherbot
Copy link

Change https://golang.org/cl/370254 mentions this issue: cmd/gorename: log 'go build' output on failure

@bcmills bcmills removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 8, 2021
gopherbot pushed a commit to golang/tools that referenced this issue Dec 8, 2021
cmd/gorename: log 'go build' output on failure
3fca6a0 
For golang/go#50043

Change-Id: I90d1e85c59d6f9c9ad30edf0180cb876c2564534
Reviewed-on: https://go-review.googlesource.com/c/tools/+/370254
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 8, 2021
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot