Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: GOEXPERIMENT=unified fails using Go 1.17 as bootstrap toolchain #50029

Closed
rsc opened this issue Dec 7, 2021 · 4 comments
Closed

build: GOEXPERIMENT=unified fails using Go 1.17 as bootstrap toolchain #50029

rsc opened this issue Dec 7, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.19

Comments

@rsc
Copy link
Contributor

rsc commented Dec 7, 2021 

% GOROOT_BOOTSTRAP=$HOME/sdk/go1.17 GOEXPERIMENT=unified ./make.bash
go: unknown GOEXPERIMENT unified
Building Go cmd/dist using /Users/rsc/sdk/go1.17. ()
go: unknown GOEXPERIMENT unified
%

I'm not sure what's going on here. It looks like maybe GOEXPERIMENT should be cleared during the use of the bootstrap toolchain in make.bash?
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 7, 2021
@rsc rsc added this to the Go1.19 milestone Dec 7, 2021
@cuonglm
Copy link
Member

cuonglm commented Dec 7, 2021

AFK now, but IIRC, there's an issue tracking this issue already (and also Matthew's CL to address it).

@rsc
Copy link
Contributor Author

rsc commented Dec 7, 2021

Thanks. I don't see it here. https://github.com/golang/go/issues?q=is%3Aissue+is%3Aopen+goexperiment+unified

@rsc
Copy link
Contributor Author

rsc commented Dec 7, 2021

Looks like maybe CL 344512 is the fix.

@cherrymui
Copy link
Member

This doesn't fail now. Probably fixed by CL https://go-review.googlesource.com/c/go/+/395879

@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
5 participants
@mdempsky @rsc @cuonglm @gopherbot @cherrymui