Skip to content

x/vuln: move CI to kokoro #50026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Dec 7, 2021 · 2 comments
Closed

x/vuln: move CI to kokoro #50026

julieqiu opened this issue Dec 7, 2021 · 2 comments
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
Unreleased

Comments

@julieqiu
Copy link
Member

julieqiu commented Dec 7, 2021

CI currently runs on TryBots, and we should move it to kokoro since we are using Go1.17 and may want to run docker tests in the future.
@julieqiu julieqiu added the x/vuln label Dec 7, 2021
@gopherbot gopherbot added this to the Unreleased milestone Dec 7, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/369994 mentions this issue: internal/worker: skip TestNewBody

gopherbot pushed a commit to golang/vuln that referenced this issue Dec 7, 2021
@julieqiu
internal/worker: skip TestNewBody
59dc5d5 
TestNewBody uses math.MaxInt which is only available in Go1.17+, so this
test is failing on TryBots.

Temporarily comment out this test until CI is moved to kokoro.

For golang/go#50026

Change-Id: Iae296a983d8a6529b690f12e0989c1f9334b7eae
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/369994
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@jba
Copy link
Contributor

jba commented Dec 9, 2021

We are able to run the checks we want on TryBots. The TryBot experience is better than kokoro (much faster turnaround, clearer CL messaging) so let's stick with it until we need something it can't provide.

@jba jba closed this as completed Dec 9, 2021
@rsc rsc unassigned jba Jun 22, 2022
@julieqiu julieqiu added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Sep 8, 2022
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
internal/worker: skip TestNewBody
6ab2a3e 
TestNewBody uses math.MaxInt which is only available in Go1.17+, so this
test is failing on TryBots.

Temporarily comment out this test until CI is moved to kokoro.

For golang/go#50026

Change-Id: Iae296a983d8a6529b690f12e0989c1f9334b7eae
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/369994
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
internal/worker: skip TestNewBody
5bad008 
TestNewBody uses math.MaxInt which is only available in Go1.17+, so this
test is failing on TryBots.

Temporarily comment out this test until CI is moved to kokoro.

For golang/go#50026

Change-Id: Iae296a983d8a6529b690f12e0989c1f9334b7eae
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/369994
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
internal/worker: skip TestNewBody
c3ec274 
TestNewBody uses math.MaxInt which is only available in Go1.17+, so this
test is failing on TryBots.

Temporarily comment out this test until CI is moved to kokoro.

For golang/go#50026

Change-Id: Iae296a983d8a6529b690f12e0989c1f9334b7eae
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/369994
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@golang golang locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
Go Security
Status: No status
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @jba