Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/asm: MOVL $x-8(SP) and LEAL x-8(SP) are different #4997

Open
rsc opened this issue Mar 7, 2013 · 5 comments
Open

cmd/asm: MOVL $x-8(SP) and LEAL x-8(SP) are different #4997

rsc opened this issue Mar 7, 2013 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@rsc
Copy link
Contributor

rsc commented Mar 7, 2013 

MOVL $x-8(SP), AX assembles to raw LEAL -8(SP), AX.
LEAL x-8(SP), AX assembles to raw LEAL (framesize-8)(SP), AX.
It's a bit confusing that they have different interpretations of x-8(SP).

Same for MOVQ on 6a.

Can wait until after Go 1 because I think I'm the only one who ever uses that form
instead of writing LEAL/LEAQ.
@rsc
Copy link
Contributor Author

rsc commented Jul 30, 2013

Comment 1:

Labels changed: added go1.2.

@rsc
Copy link
Contributor Author

rsc commented Sep 6, 2013

Comment 2:

Not important for Go 1.2.

Labels changed: added go1.3maybe, removed go1.2.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added repo-main.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc
Copy link
Contributor Author

rsc commented Jun 8, 2015

Need to check if this is still true after all the shakeup.

@rsc rsc changed the title cmd/6a, cmd/8a: MOVL $x-8(SP) and LEAL x-8(SP) are different cmd/asm: MOVL $x-8(SP) and LEAL x-8(SP) are different Jun 8, 2015
@rsc rsc added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
1 participant
@rsc