-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: failures with "symbol type.[…] listed multiple times" on freebsd-amd64-12_2 since 2021-11-24 #49967
Comments
Marking as release-blocker for Go 1.18 because this failure mode appears to be new as of November. (CC @jeremyfaller for routing) |
So far these failures have only been seen on the |
The error is probably from the linker. May be the same cause s #49752. |
I haven't been trying to reproduce this (I'm going after #46272 (comment)), but this has reproduced in 2/5 of my crashes so far with:
|
@prattmic do you think this could be a result from the memory corruption from the other bug, or this is a different issue? Thanks. |
It seems plausible, but I haven't seen enough details to have confidence one way or another. |
Same as #49752 . We can revisit once we have FreeBSD builders with kernel fixed. |
https://storage.googleapis.com/go-build-log/301db3f5/freebsd-amd64-12_2_faaeee15.log (a TryBot). I think @heschi pushed an updated FreeBSD 13 builder today — is there a fix available for 12.2 as well? |
#46272 (comment) noted that the fix is cherry-picked into FreeBSD 12 as well. I believe https://lists.freebsd.org/archives/freebsd-snapshots/2021-December/000037.html is the latest 12 snapshot. |
We're currently on 12.2, which doesn't have the fix. Would you like me to upgrade us to the latest 12.3 snapshot? |
Since 12.2 has TryBot failures that we can't easily work around by adding test skips, I think we would add an updated 12.3 builder as soon as is feasible and turn off the 12.2 TryBots. (Probably we should keep the 12.2 post-submit builders up until the 12.3 builders have run for enough CLs to be confident that there are no significant regressions from 12.2 to 12.3.) |
Change https://golang.org/cl/375695 mentions this issue: |
With the XSAVE bug fix. For golang/go#49967, golang/go#46272. Change-Id: Ie0711ba83e4f15d26e6fe89e89c80b7c3ad2c23c Reviewed-on: https://go-review.googlesource.com/c/build/+/375695 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
Change https://golang.org/cl/377474 mentions this issue: |
I am pretty sure this falls into the same category as #49752, which is now marked fixed-- I am going to try one more goswarm test on this one to check that the problem is no longer reproducible. |
OK, I ran some tests with goswarm overnight (10 motes running all.bash for roughly 20 hours) using the freebsd-amd64-12_3 builder, which incorporates the fix for the problem identified in #46272. No new failures with the "unreachable sym" mode. I am going to close out this bug. For posterity, here are the failures that did turn up: 15 times:
7 times:
4 times:
5 times:
then maybe a half dozen other singleton failures. |
That's #6999, open since 2013 (and not FreeBSD-specific). 😩
That looks like #19381, but curiously it hasn't failed in the dashboard in the past few years. Maybe it's sensitive to machine load?
I don't see any issues filed at all for that one. 🤔
#32986, open since 2019. |
Remove freebsd 12.2, which is replaced by 12.3 with the XSAVE fix. Move freebsd 11.* to N2 machines, which are not affected. Remove openbsd and netbsd e2/n1/n2/n2d-specific configurations now that we have mostly understood the nature of that problem. Keep one around so that the runtime team can create gomotes. Move the "official" builder to the n2 cpu that works. For golang/go#49967, golang/go#49209, golang/go#40561. Fixes golang/go#50496. Change-Id: If6989317f06cbec95d5addb19d9e968aecfa3f8a Reviewed-on: https://go-review.googlesource.com/c/build/+/377474 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Alex Rakoczy <alex@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
greplogs --dashboard -md -l -e 'symbol type.* listed multiple times'
2021-12-02T15:48:58-28ec0fd/freebsd-amd64-12_2
2021-12-01T18:47:44-3c63f30-08ecdf7/freebsd-amd64-12_2
2021-11-24T05:36:54-7cf1f38-47db3bb/freebsd-amd64-12_2
The text was updated successfully, but these errors were encountered: