Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/retrybuilds: convert authentication to use Identity Aware Proxy #49963

Closed
cagedmantis opened this issue Dec 3, 2021 · 2 comments
Closed

x/build/cmd/retrybuilds: convert authentication to use Identity Aware Proxy #49963

cagedmantis opened this issue Dec 3, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
Go Release Team
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

With the migration to use Identity Aware Proxy for the GRPC servers on the coordinator, authentication no longer works with the client. We should convert authentication over to use IAP.

@golang/release
@cagedmantis cagedmantis added the Builders x/build issues (builders, bots, dashboards) label Dec 3, 2021
@cagedmantis cagedmantis added this to the Backlog milestone Dec 3, 2021
@cagedmantis cagedmantis self-assigned this Dec 3, 2021
@heschi heschi added this to In Progress in Go Release Team Dec 7, 2021
@cagedmantis cagedmantis moved this from In Progress to Planned in Go Release Team Jan 4, 2022
@cagedmantis
Copy link
Contributor Author

The authorization entry in the GRPC metadata is being removed before the call reaches the coordinator. https://go.googlesource.com/build/+/7c20028b5a5cd47985e6d91db482035d98b45f23/cmd/coordinator/results.go#150

@gopherbot
Copy link

Change https://golang.org/cl/378556 mentions this issue: cmd/coordinator, cmd/retrybuilds: modify authentication for retrybuilds

@dmitshur dmitshur moved this from Planned to In Progress in Go Release Team Jan 14, 2022
Go Release Team automation moved this from In Progress to Done Jan 14, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot